helix icon indicating copy to clipboard operation
helix copied to clipboard

Separate dirty part of file-name status line element into its own file-dirty element

Open cbclemmer opened this issue 3 years ago • 6 comments

attempts to close #4686

Adds a new "file-dirty" status line element that can replace the [+] symbol that appears after the file name. This allows the element to be added before the "file-name" element so the dirty symbol will be visible for long file/directory names. Adds logic to keep the dirty element after the "file-name" element if it is not in the list. This keeps current config files and the default configuration working as they were before while allowing the dirty element to be placed wherever the config file specifies.

cbclemmer avatar Nov 13 '22 17:11 cbclemmer

Let's call this "FileModificationIndicator"

the-mikedavis avatar Nov 13 '22 17:11 the-mikedavis

@the-mikedavis Ok, I found a reference to dirty somewhere so that's why I called it that.

cbclemmer avatar Nov 13 '22 17:11 cbclemmer

@the-mikedavis I changed it along with the other related variables.

cbclemmer avatar Nov 13 '22 19:11 cbclemmer

@kirawi Is there anything you are waiting for me on this PR?

cbclemmer avatar Dec 07 '22 18:12 cbclemmer

@the-mikedavis I feel like this is a fairly uncontroversial change.

kirawi avatar Jan 14 '23 15:01 kirawi

@kirawi @the-mikedavis The tests are passing now. I didn't see that before.

cbclemmer avatar Jan 14 '23 18:01 cbclemmer

We could make the element customizable.

theteachr avatar Feb 08 '23 15:02 theteachr

I believe this one needs an update in the configuration docs.

theteachr avatar Feb 14 '23 15:02 theteachr

Ah good catch, a new line for this should be added in this table https://github.com/helix-editor/helix/blob/0a7c697dd785111626c8f47a36e07381f55c2e83/book/src/configuration.md#L93

the-mikedavis avatar Feb 14 '23 15:02 the-mikedavis

Created https://github.com/helix-editor/helix/pull/6036 to update the docs.

theteachr avatar Feb 18 '23 05:02 theteachr