helix icon indicating copy to clipboard operation
helix copied to clipboard

update catppucin themes

Open ivktac opened this issue 2 years ago • 2 comments

  • added missing scopes attribute, constant.builtin, punctuation.special, ui.cursorcolumn.primary, diagnostic.*
  • changed foreground text in statusline and bufferline to make more visible
  • changed dark theme to the extended version
  • patched scopes to another colors for better highlights

ivktac avatar Nov 03 '22 11:11 ivktac

I applied your suggestions. Could you @ChrHorn review it again?

ivktac avatar Nov 03 '22 14:11 ivktac

Ok, I managed to take a look at it.

Personally, I am against the changes to the UI. The theme is a carbon copy of them neovim variant and I would prefer to keep it that way. The lower contrast ratio on some UI elements is intentional and only on elements that should not draw too much focus.

I am fine with:

  • Usage of inheritance, but could you use mocha as the base theme? It is basically the base cappuccino theme. Light and dark variants should be able to inherit just fine without any extra modifications needed, just use the different palettes.
  • The additional scopes and the cursorcolumn addition
  • The color changes for links and diffs

Also, could you restore "type.enum.variant" = "peach". It's not in the docs but is used by some queries.

ChrHorn avatar Nov 06 '22 09:11 ChrHorn

Are all the remaining items resolved here now?

archseer avatar Nov 17 '22 01:11 archseer

Not yet, needs some more adjustments.

ChrHorn avatar Nov 18 '22 07:11 ChrHorn

superseded by #5404

ivktac avatar Jan 06 '23 10:01 ivktac