helix
helix copied to clipboard
update catppucin themes
- added missing scopes
attribute
,constant.builtin
,punctuation.special
,ui.cursorcolumn.primary
,diagnostic.*
- changed foreground text in statusline and bufferline to make more visible
- changed dark theme to the extended version
- patched scopes to another colors for better highlights
I applied your suggestions. Could you @ChrHorn review it again?
Ok, I managed to take a look at it.
Personally, I am against the changes to the UI. The theme is a carbon copy of them neovim variant and I would prefer to keep it that way. The lower contrast ratio on some UI elements is intentional and only on elements that should not draw too much focus.
I am fine with:
- Usage of inheritance, but could you use
mocha
as the base theme? It is basically the base cappuccino theme. Light and dark variants should be able to inherit just fine without any extra modifications needed, just use the different palettes. - The additional scopes and the
cursorcolumn
addition - The color changes for links and diffs
Also, could you restore "type.enum.variant" = "peach"
. It's not in the docs but is used by some queries.
Are all the remaining items resolved here now?
Not yet, needs some more adjustments.
superseded by #5404