helix
helix copied to clipboard
Provide option to completely disable LSP
I had had this code sitting around in a branch I'm working on already before #4391 became necessary in order to turn off LSP for the integration tests. It slows them down and is totally unnecessary until we figure out a good way to do integration tests with real language servers.
I'm making this PR as a proposed different way to approach this, where this is generalized into a user config option exposed to the user. I figure that while my motivation for this was reducing noise in the integration tests, this could conceivably be desirable by some users without having to e.g. compile out LSP integration with a feature flag.
Another benefit is that when we do get to integration tests around LSP, we won't need to manually specify a language config; we'll just need to set this one boolean config setting in the test invocation, which is a lot less tedious, and allows always testing the same default configs that ship to users.
With that said, I don't actually have any strong feelings about keeping this, I just thought it was worth proposing and seeing what everyone thinks since I had already done it. I'm perfectly content leaving it the way it is now.
Done
@archseer any thoughts?