helix
helix copied to clipboard
helix-editor
feat(themes): add mode-specific styles to the tokyonight themes
This little PR adds mode-specific colors to both tokyonight themes, using the same reasoning as in https://github.com/helix-editor/helix/pull/3098, with one exception: I went with orange for the selection like in the similar cattpuccin themes. IMO it fits well in the theme, while still distinguishing the mode well enough.
tokyonight
tokyonight_storm
Seems like we made the same PR basically at the same time. Would you be fine if i merge some of my change into yours? (Also i kind of dislike the orange)
Check #4416 for my pr
Oh, now that's a coincidence! Thanks for the heads up, @SoraTenshi. I merged your changes and took over your colors, except that I left blue instead of cyan. I was quite uncertain about it, but cyan feels a bit too... electric? aggressive? ... for a normal, initially active mode.
I like your selection of the other colors though: "green" is lighter than "light_green" (whatever may be the reason), but it definitely fits in the theme much better. Regarding "magenta", i was initially sceptical, because it's a bit darker compared to "green", but the more I look at it, the more I like it, and I think it matches "blue" and "green" perfectly.
tokyonight
tokyonight_storm
Hey guys! Love the colors chosen here, and I do agree magenta for select mode fits the other two softer colors very nicely. Very nice of you to do this, thank you!
Looks good! And thanks for cleaning up the storm variant with the inherits 👍
