helix
helix copied to clipboard
helix-editor
Support drawing popup frame
Drawing borders for popups feel like a good default whereas having a config option for it feels a bit overkill. I suppose some might prefer a sleeker look without the border?
I think an option for it seems ok. I prefer the borderless look but I've seen some discussions and matrix messages about wanting a border around popups
I want this to be default. I use dracula theme, and in order to distinguish the popup, I have to modify the theme:
And I haven't seen any popup in nvim without borders. The same codeactionin nvim with lspsage.nvim plugin:
This change covers popups (like signature-help) but not menus (completion, code-actions). I think an option to enable/disable borders on both would be good
This change covers popups (like signature-help) but not menus (completion, code-actions). I think an option to enable/disable borders on both would be good
It covers now both menus and popups, with settings to enable one of them, both, or none.
Updated after the changes to popups having scrollbars. Also fixed the unnecessary leading newlines in popups displayed for the selected menu item.
I decided to take out the changes related to selection popup whitespace since it has nothing to do with borders. The pr containing those changes is #4902
I think this pr is ready for merge. The last force-push was only to fix a merge conflict with newer changes on master.
Nice job on the PR, has been a staple in my fork for like ever. Minor bug that i noticed tho: DAP mode (list all variables - Spc g v) does not properly draw the frame.
I cleaned up the code, added popup-borders typable command, and fixed the issues with dap variable popup (thanks @SoraTenshi), and with menu only border setting.
I think this PR is from my perspective in a good state and unless requested i dont plan to do any changes to it. To celebrate this PR's birthday, can i get a review please?