added bufferline colors to 15 themes

[txtyash]

Fixes visual discrepancy with a few themes by adding bufferline colors. There's one issue in a few commits where I've added fg to ui.bufferline.background where it was unnecessary. I only realized later. It does not break anything though.

[txtyash]

There's a lot of themes btw. Helix should stop adding themes at some point. And some themes like acme, base16_light, etc. which are poorly built should be removed.

[txtyash]

Then at least adding a theme picker is necessary.

[archseer]

:theme already offers a live preview.

[David-Else]

How about merging https://github.com/helix-editor/helix/pull/3234 sooner rather than later and hopefully remove the endless theme fix pull requests as a result?

[txtyash]

How about merging #3234 sooner rather than later and hopefully remove the endless theme fix pull requests as a result?

The linter only finds the mistakes in themes right? So, they still have to be fixed manually?

[archseer]

@David-Else some of these fixes are adding new styles for features that didn't exist when the theme was initially written. We don't block merging new features on adding missing styles to all themes since this is dependent on theme authors.

[David-Else]

How about merging #3234 sooner rather than later and hopefully remove the endless theme fix pull requests as a result?

The linter only finds the mistakes in themes right? So, they still have to be fixed manually?

Yes, pre-linter they currently need to be fixed manually.

The linter is merged now, people just need to make sure to use it as it is not yet in CI, see bottom of https://github.com/helix-editor/helix/blob/master/book/src/themes.md

[the-mikedavis]

Thanks!