helix
helix copied to clipboard
Add option to skip the first indent guide
coming from my previous setup, the first indent guide are a bit distracting. Therefore the option to disable this
current:

enabled:

my neovim config for comparison (using indent-blankline with show_first_indent_level = false

Could we have a description or even better screenshots of what this does? Is there a related issue to link?
Is this configurable in other editors? Why not make it an usize and skip that many levels: starting_indent += skip
Could we have a description or even better screenshots of what this does? Is there a related issue to link?
ah my bad! updated the discription
Is this configurable in other editors? Why not make it an usize and skip that many levels: starting_indent += skip
in the nvim plugin it is, i couldnt find any such settings in vscode, but in gui editors i find the indent guide to be much more subtle so the first line isnt as distracting to me.
Is this configurable in other editors? Why not make it an
usizeand skip that many levels:starting_indent += skip
@archseer converted it to a number
I quite like this. Can't help but think this would be an uncontroversial default.
in gui editors i find the indent guide to be much more subtle so the first line isnt as distracting to me.
The color can be configured to be something less loud using the ui.virtual.indent-guide theme key btw, it does look quite distracting in your screenshot.
The config option will have to be updated in the book too.
The color can be configured to be something less loud using the ui.virtual.indent-guide theme key btw, it does look quite distracting in your screenshot.
good to know!
The config option will have to be updated in the book too.
done
Rather than making this configurable, should we just always skip the first level? Not sure what the default behavior is elsewhere
I find indent guides unusable without this, but it probably should be configurable and off by default because a new Helix user wouldn't expect the first indent level to be different. Adding skip-levels = 1 to the example in the documentation should already ensure that users who want to try out indent guides don't miss out on this new feature.
The existence of these three Vim issues supports my conclusion: issue 1, issue 2, issue 3.
Played with this just now. I feel like it works particularly well without spaces/tabs being rendered, but feels a little empty with them present. So I can see and agree that leaving it on by default is probably better.
in gui editors i find the indent guide to be much more subtle so the first line isnt as distracting to me.
The color can be configured to be something less loud using the
ui.virtual.indent-guidetheme key btw, it does look quite distracting in your screenshot.
Side note: I have kept the above theme (everforest) up to date in my own theme repository which includes the style for indent guides among other changes. I'll make a PR to update it later this week.
@archseer
I would say the pr is done, except a potential change of defaults.