helix icon indicating copy to clipboard operation
helix copied to clipboard

Add option to skip the first indent guide

Open robinvd opened this issue 3 years ago • 11 comments

coming from my previous setup, the first indent guide are a bit distracting. Therefore the option to disable this

current:

image

enabled: image

my neovim config for comparison (using indent-blankline with show_first_indent_level = false

image

robinvd avatar Sep 12 '22 15:09 robinvd

Could we have a description or even better screenshots of what this does? Is there a related issue to link?

EpocSquadron avatar Sep 12 '22 17:09 EpocSquadron

Is this configurable in other editors? Why not make it an usize and skip that many levels: starting_indent += skip

archseer avatar Sep 13 '22 00:09 archseer

Could we have a description or even better screenshots of what this does? Is there a related issue to link?

ah my bad! updated the discription

Is this configurable in other editors? Why not make it an usize and skip that many levels: starting_indent += skip

in the nvim plugin it is, i couldnt find any such settings in vscode, but in gui editors i find the indent guide to be much more subtle so the first line isnt as distracting to me.

robinvd avatar Sep 13 '22 07:09 robinvd

Is this configurable in other editors? Why not make it an usize and skip that many levels: starting_indent += skip

@archseer converted it to a number

robinvd avatar Sep 13 '22 08:09 robinvd

I quite like this. Can't help but think this would be an uncontroversial default.

EpocSquadron avatar Sep 13 '22 11:09 EpocSquadron

in gui editors i find the indent guide to be much more subtle so the first line isnt as distracting to me.

The color can be configured to be something less loud using the ui.virtual.indent-guide theme key btw, it does look quite distracting in your screenshot.

The config option will have to be updated in the book too.

sudormrfbin avatar Sep 13 '22 11:09 sudormrfbin

The color can be configured to be something less loud using the ui.virtual.indent-guide theme key btw, it does look quite distracting in your screenshot.

good to know!

The config option will have to be updated in the book too.

done

robinvd avatar Sep 13 '22 12:09 robinvd

Rather than making this configurable, should we just always skip the first level? Not sure what the default behavior is elsewhere

archseer avatar Sep 16 '22 16:09 archseer

I find indent guides unusable without this, but it probably should be configurable and off by default because a new Helix user wouldn't expect the first indent level to be different. Adding skip-levels = 1 to the example in the documentation should already ensure that users who want to try out indent guides don't miss out on this new feature.

The existence of these three Vim issues supports my conclusion: issue 1, issue 2, issue 3.

Ordoviz avatar Sep 17 '22 08:09 Ordoviz

Played with this just now. I feel like it works particularly well without spaces/tabs being rendered, but feels a little empty with them present. So I can see and agree that leaving it on by default is probably better.

EpocSquadron avatar Sep 17 '22 20:09 EpocSquadron

in gui editors i find the indent guide to be much more subtle so the first line isnt as distracting to me.

The color can be configured to be something less loud using the ui.virtual.indent-guide theme key btw, it does look quite distracting in your screenshot.

Side note: I have kept the above theme (everforest) up to date in my own theme repository which includes the style for indent guides among other changes. I'll make a PR to update it later this week.

CptPotato avatar Sep 19 '22 15:09 CptPotato

@archseer

I would say the pr is done, except a potential change of defaults.

robinvd avatar Sep 26 '22 07:09 robinvd