helix icon indicating copy to clipboard operation
helix copied to clipboard

Published 20 hours ago • verified publisher icon helix-editor

commands: Make no arg ':theme' show name

Open jamesodhunt opened this issue 2 years ago • 6 comments

Most commands that accept an argument show their current value if no argument is specified. The :theme command previously displayed an error message in the status bar if not provided with an argument:

Theme name not provided

It now shows the current theme name in the status bar if no argument is specified.

Signed-off-by: James O. D. Hunt [email protected]

jamesodhunt avatar Sep 07 '22 21:09 jamesodhunt

The description of the command should be updated to reflect that it can return the current theme when no arguments are passed

the-mikedavis avatar Sep 07 '22 22:09 the-mikedavis

@the-mikedavis - Description updated.

jamesodhunt avatar Sep 08 '22 18:09 jamesodhunt

Anything else to do on this PR?

jamesodhunt avatar Sep 13 '22 06:09 jamesodhunt

LGTM

EpocSquadron avatar Sep 18 '22 12:09 EpocSquadron

Branch rebased to resolve the conflict.

jamesodhunt avatar Oct 04 '22 18:10 jamesodhunt

This has been open a month now. The checks have passed and there are no unanswered question fwics.

It's not a major feature, but I do feel it helps usability (it helped me to develop my own theme atleast).

Any chance it could land soon to potentially help others? :smile:

jamesodhunt avatar Oct 07 '22 08:10 jamesodhunt