helix icon indicating copy to clipboard operation
helix copied to clipboard

fix: wait for is_exit_success with a timeout limit

Open prscoelho opened this issue 1 year ago • 2 comments

Fixes #3655

Not sure about the logging or the actual timeout duration, please advise.

I want to test this on my work pc tomorrow because that's where it was failing, but replacing xsel with a sleep seems to return from timeout early, so it should be good.

prscoelho avatar Sep 04 '22 23:09 prscoelho

Yep, I can confirm that this fixes the problem on my work computer.

prscoelho avatar Sep 05 '22 09:09 prscoelho

(For visibility, replied here https://github.com/helix-editor/helix/pull/3696#discussion_r1014122780)

archseer avatar Nov 04 '22 14:11 archseer

@archseer I pushed some changes, I dunno if you got a notification for it. Let me know for next time if you did though, not trying to spam.

prscoelho avatar Dec 13 '22 16:12 prscoelho

clsoing this one as stale. Thank you for contributing!

pascalkuthe avatar Apr 13 '24 23:04 pascalkuthe