helix icon indicating copy to clipboard operation
helix copied to clipboard

Add bracketed paste

Open groves opened this issue 3 years ago • 0 comments
trafficstars

This adds bracketed paste support to fix https://github.com/helix-editor/helix/issues/2239. It's based on this PR on crossterm, so that will need to land and be released before this can be merged.

I haven't done any serious benchmarking, but I tried the Moby Dick Workout. Pasting with this enabled took maybe a tenth of a second to get the whole meg of book in there. Without this, I think it would've taken a day or so.

groves avatar Jul 28 '22 21:07 groves

Is there a need for Space-p after this is merged?

sfarq avatar Aug 22 '22 13:08 sfarq

Yes, not all terminals support bracketed paste (I also prefer space+p over ctrl+v)

archseer avatar Aug 23 '22 05:08 archseer

Looks like Windows sends paste events regardless, so we need to get this merged before 22.08 is released (ctrl+v panics on windows)

archseer avatar Aug 23 '22 05:08 archseer

That's frustrating that Windows sends bracketed pastes regardless. This is ready to go as far as I know.

If this PR needs additional work, we could also disable the bracketed-paste feature in crossterm. That would turn off the parsing entirely. I'd prefer getting the PR in, naturally 😅

groves avatar Aug 23 '22 12:08 groves