helix icon indicating copy to clipboard operation
helix copied to clipboard

fix regression / conflict of Home/End in pickers

Open Axlefublr opened this issue 7 months ago • 5 comments

Previously, Home/End went to the start/end of the input in a picker. Since recently, Home/End started to go to the first/last item in the results.
Now the latter is done via ctrl+Home/End, and Home/End is back to their unsurprising behavior.
I updated the part in the documentation about this, as well.

Axlefublr avatar May 29 '25 05:05 Axlefublr

This is changing code that has been untouched for years, and I think it's changing the desired behaviour. Since when did this regress?

archseer avatar May 29 '25 08:05 archseer

wait really? I've been using helix since 2024.08.18, and ever since then I remember home/end going to start/end of the input. recently I updated to latest master, and that suddenly stopped working. I checked the documentation on picker hotkeys, and the fact that home/end were both for going to start/end of the input, and going to the first/last item, I surmised that this change was due to a missed conflict, and was recent. is this all not the case? and if so, would you consider accepting this pr regardless? ctrl+home/end is widely accepted to mean "go to the absolute start/end", and just home/end to mean "go to the start/end of the line". it may suck for some people to get used to the new mappings, but ultimately I think they make more sense, and will end up making for a better experience.

Axlefublr avatar May 29 '25 08:05 Axlefublr

and the fact that home/end were both for going to start/end of the input, and going to the first/last item

nevermind, I missed the start of the next (prompt) section, and thought the home/end in that section were part of the previous one (picker). my other points stand though

Axlefublr avatar May 29 '25 08:05 Axlefublr

yeah, this actually makes sense! at this point i am too used to using Home/End in every program

amqndin avatar May 29 '25 10:05 amqndin

This makes a lot of intuitive sense to me. I don't use the Home/End keys personally but I've always thought of them as analogous to C-A and C-E. Any application I've ever used these keys in, they've been a linewise operation. So I think this change makes a lot of sense for aligning the behavior of these keys with the convention most users will expect.

ficd0 avatar May 29 '25 16:05 ficd0