helix icon indicating copy to clipboard operation
helix copied to clipboard

fix docs, improve global-search and jumplist picker

Open woojiq opened this issue 4 months ago • 1 comments

These are a few patches I've collected while using Helix. Let the world finally see them.

commit 94db1511f8f7789fe7eed378d1e0407aff3bcca2 : docs: mention <space>g changed file picker. This was missed in the #5645

These two are personal preferences, but I think they're fair: commit a4b5b4c16bbfc65efce7cddcd4e0c36fb0e2d4b0 : picker(jumplist): show newest options on top instead of bottom commit ef13bf544daec50034009291bc61030831d43ee7 : picker(global-search): append line number to found options

You can reject them all, select only docs commit, or do whatever you want :)

woojiq avatar Apr 01 '24 19:04 woojiq

commit https://github.com/helix-editor/helix/commit/ef13bf544daec50034009291bc61030831d43ee7 : picker(global-search): append line number to found options

the rest lgtm but I don't think this should be added here. If we are going to do this it should be a separate column as part of #9647 but I am even critical of that. What is your usecase here. I don't think people generally search by line (if you already know the line why bother searching).

We could show gutters with line number instead (may be nice for diff gutter aswell) but that also takes up more vertical space

pascalkuthe avatar Apr 01 '24 23:04 pascalkuthe

What is your usecase here.

It's hard to explain, you have to feel it. Helped me on a large codebase without Lsp. But as I said, these are just my preferences, I can live without it on master.

We could show gutters with line number instead (may be nice for diff gutter aswell) but that also takes up more vertical space

This will work for me too. For now, I can remove it and maybe create an issue to request config option: "line numbers in pickers" so that all possible pickers are consistent (jumplist, buffer, symbol, etc). Then you will decide whether this feature has the right to live.

woojiq avatar Apr 02 '24 05:04 woojiq