blockchain-http icon indicating copy to clipboard operation
blockchain-http copied to clipboard

broken cursor on /cities/:id/hotspots endpoint

Open allenan opened this issue 3 years ago • 5 comments

following the cursor on https://api.helium.io/v1/cities/bmV3IHlvcmtuZXcgeW9ya3VuaXRlZCBzdGF0ZXM/hotspots (New York) for example results in a "not found" error

allenan avatar Mar 08 '22 20:03 allenan

I believe this is the issue in the source:

File: /blockchain-http/src/bh_route_cities.erl

Line 20: -define(S_CITY_HOTSPOT_LIST_BEFORE, "hotspor_city_list_before").

The fix is to correct the misspelling of hotspor to hotspot. ;-)

Cheers

mortonmj avatar Mar 09 '22 15:03 mortonmj

I believe this is the issue in the source:

File: /blockchain-http/src/bh_route_cities.erl

Line 20: -define(S_CITY_HOTSPOT_LIST_BEFORE, "hotspor_city_list_before").

The fix is to correct the misspelling of hotspor to hotspot. ;-)

Good typo catch. I don't believe that's he issue since that is only the identifier used in the query cache. Did you confirm that it actually fixes the issue here?

madninja avatar Mar 09 '22 20:03 madninja

I wish I had the setup to do so. I have not confirmed this would fix the issue. Apologies if this misled. Just wanted to report this observation and coincidence.

mortonmj avatar Mar 09 '22 21:03 mortonmj

Not a coincidence but a sharp eye for spelling mistakes.. May be worth stating it as a separate bug next time or at least not make it sounds like "the fix"

madninja avatar Mar 09 '22 21:03 madninja

Agree. Thanks for investigating.

mortonmj avatar Mar 09 '22 21:03 mortonmj