blockchain-core icon indicating copy to clipboard operation
blockchain-core copied to clipboard

Fix miner#1779 by reverting PR 1412

Open dpezely opened this issue 2 years ago • 2 comments

Fix https://github.com/helium/miner/issues/1779 by reverting https://github.com/helium/blockchain-core/pull/1412 per conversation with @mikev

  • The lora library call reporting as undefined was invoked from the mentioned PR
  • Since that feature requires a future chain-var that has been put on hold, we can revert the feature by reversing its diff
  • Later, we can track why that lora library call is no longer available; e.g., API changed?
  • Preserved Pierre's additional fixes to pre-existing tests:
    • in test/blockchain_state_channel_SUITE.erl
wget https://github.com/helium/blockchain-core/pull/1412.diff
patch -p1 --reverse < 1412.diff

dpezely avatar Aug 08 '22 18:08 dpezely

We added the dep to the app file so this maybe doesn't need to be reverted?

Vagabond avatar Aug 08 '22 19:08 Vagabond

We added the dep to the app file so this maybe doesn't need to be reverted?

Now, I'm really confused. New tests wouldn't have passed prior to creating the original PR if there was such a missing dependency.

Everything with blockchain-core remain a bit alien to me since I don't follow the relevant Discord channels or its PRs closely enough. Therefore, I'll leave that decision to others. My rationale was that if this feature requires a chain var which has been put on hold, there's no reason for this feature code to exist (for now).

dpezely avatar Aug 08 '22 20:08 dpezely