blockchain-core icon indicating copy to clipboard operation
blockchain-core copied to clipboard

State Channel Re-close test

Open michaeldjeffrey opened this issue 3 years ago • 4 comments

Ensure that submitting a non-dispute state channel close will not make it through when a state channel has already been legitimately closed.

Also update the types of txns a state_channel_client will consider disputable to only those from the original state channel owner. To prevent filing disputes against other disputers.

michaeldjeffrey avatar Feb 09 '22 23:02 michaeldjeffrey

What happens if the client has a newer version of the state channel that is legitimate?

Vagabond avatar Feb 11 '22 16:02 Vagabond

What happens if the client has a newer version of the state channel that is legitimate?

That's the ultimate issue because at that point it means that server side will start "lying"

macpie avatar Feb 11 '22 17:02 macpie

What happens if the client has a newer version of the state channel that is legitimate?

That's the ultimate issue because at that point it means that server side will start "lying"

No, that's not true, the router may just be offline.

Imagine this scenario:

Router A is offline, but before it went offline it paid B with a nonce of 20 and also paid C with a nonce of 21.

The state channel expiry time has arrived, A is offline so it cannot close. B sends the latest copy of the state channel with nonce 20. Then C sends its close with a nonce of 21 which should supercede the nonce 20 close, but not conflict with it.

Vagabond avatar Feb 14 '22 15:02 Vagabond

@michaeldjeffrey ping

Vagabond avatar Feb 23 '22 14:02 Vagabond