blockchain-core icon indicating copy to clipboard operation
blockchain-core copied to clipboard

Mv/netid transition

Open mikev opened this issue 3 years ago • 4 comments

Changes needed to support the transtion to Helium's official NetID. NetIDs support a limited address range, e.g. a class 6 NetID supports 1,024 addresses. We plan to support a list of NetIDs. In the future we can simply add new NetIDs to the chain var. This will allow for future end-device growth.

mikev avatar Nov 01 '21 21:11 mikev

I think we should take all the net id functions out of core (put them in Router for now until lora lib). The chain var should just be storing [non_neg_integer()]

macpie avatar Nov 01 '21 23:11 macpie

I think we should take all the net id functions out of core (put them in Router for now until lora lib). The chain var should just be storing [non_neg_integer()]

Within the 32-bit DevAddr there are variable length fields. Unfortunately the Miner now needs to extract the variable length nwk_addr and netid. Therefore it needs the two new functions: get_nwk_addr and get_netid.

This is now moved into the erlang-lorawan library, which is referenced by both the Miner and Router.

mikev avatar Nov 02 '21 16:11 mikev

I think we should take all the net id functions out of core (put them in Router for now until lora lib). The chain var should just be storing [non_neg_integer()]

Done. Most logic is now in the erlang-lorawan repo.

mikev avatar Dec 01 '21 22:12 mikev

Ping. What's the status of this feature? Will it be merged anytime soon?

@mikev Was this intended to be part of router#615 ticket that you originally created?

dpezely avatar Jul 06 '22 16:07 dpezely