helidon icon indicating copy to clipboard operation
helidon copied to clipboard

Published 20 hours ago • verified publisher icon helidon-io

Helidon DbClient JSON support

Open Tomas-Kraus opened this issue 3 years ago • 1 comments

Added support to mark database as case insensitive in config file. This is required to run tests in both MySQL and Oracle DB with some shared code, because MySQL uses lower case identifiers and Oracle DB upper case by default. JSON support verified against 21c in OCI:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running io.helidon.tests.integration.dbclient.jdbc.oradb.ora21c.OraDbJsonSupportIT
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.964 s - in io.helidon.tests.integration.dbclient.jdbc.oradb.ora21c.OraDbJsonSupportIT
[INFO] Running io.helidon.tests.integration.dbclient.jdbc.oradb.tests.JsonDateTimeIT
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.494 s - in io.helidon.tests.integration.dbclient.jdbc.oradb.tests.JsonDateTimeIT
[INFO] Running io.helidon.tests.integration.dbclient.jdbc.oradb.tests.JsonSupportIT
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.137 s - in io.helidon.tests.integration.dbclient.jdbc.oradb.tests.JsonSupportIT
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0

And PostgreSQL/MySQL:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running io.helidon.tests.integration.dbclient.jdbc.oradb.tests.JsonDateTimeIT
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.435 s - in io.helidon.tests.integration.dbclient.jdbc.oradb.tests.JsonDateTimeIT
[INFO] Running io.helidon.tests.integration.dbclient.jdbc.oradb.tests.JsonSupportIT
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.043 s - in io.helidon.tests.integration.dbclient.jdbc.oradb.tests.JsonSupportIT
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0

Tomas-Kraus avatar Jun 17 '21 13:06 Tomas-Kraus

Anyway, this PR is blocked by Oracle JDBC driver release so there is no reason to rush. I'll fix notes from Tomas L. and we can discuss whether to change artifactId now or later.

Tomas-Kraus avatar Jul 22 '21 10:07 Tomas-Kraus

I am closing this PR, as it is not being worked on. Please @Tomas-Kraus create a new PR when you resolve the comments and rebase on latest.

tomas-langer avatar Feb 08 '23 12:02 tomas-langer