admin-color-schemer icon indicating copy to clipboard operation
admin-color-schemer copied to clipboard

Not working with check boxes

Open Blindeman opened this issue 4 years ago • 4 comments

If you look at screen options for example, I can't see which options are checked or not. I'm using WP 5.5.1, the most recent TwentyTwenty theme, Admin Color Schemer 1.1 and no other plugins. I just chose colors for the 4 basic options. I was able to reproduce this on another website.

Screenshot_2020-10-06 Dashboard ‹ Gedichtenlaboratorium — WordPress

Blindeman avatar Oct 06 '20 20:10 Blindeman

I've also noticed this and can confirm on WP 5.5.1 with GeneratePress and Admin Color Schemer 1.1. Makes bulk actions on plugins/posts mostly unusable.

uamv avatar Oct 07 '20 19:10 uamv

This is still an issue as of Admin Color Schemer v1.1 and WP v5.8. The problem is with this line (L53) in the scheme.css file, which overwrites the content: attribute from the load-styles.css file:

input[type=checkbox]:checked::before {
  content: url("data:image/svg+xml;utf8,%3Csvg%20xmlns%3D%27http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%27%20viewBox%3D%270%200%2020%2020%27%3E%3Cpath%20d%3D%27M14.83%204.89l1.34.94-5.81%208.38H9.02L5.78%209.67l1.34-1.25%202.57%202.4z%27%20fill%3D%27%23str-slice('#7e8993', 2, -1)%27%2F%3E%3C%2Fsvg%3E"); }

This results in the checkmark icon not being loaded. Schermafbeelding 2021-08-03 om 17 05 21

Changing the theme colours from the "ACS custom set" back to the default colours in Profile settings fixes the missing icon immediately. Hope y'all can find the cause of this issue 😊

lexpostma avatar Aug 03 '21 15:08 lexpostma

@helen would an acceptable fix for this be removing the line indicated above? This is what I've done locally – reverting the checkboxes to their default gray color. Happy to drop a pull request if that is all that may be needed here.

uamv avatar Oct 01 '21 13:10 uamv

I'd say that's an acceptable fix, yes. I overwrote it myself in my custom theme and that worked fine. But you didn't ask me 😇

lexpostma avatar Oct 09 '21 19:10 lexpostma