ManimML icon indicating copy to clipboard operation
ManimML copied to clipboard

NN scaling issue with Convolutional3DLayer

Open fhnaumann opened this issue 2 years ago • 2 comments

At some point there was code commited changing the behaviour of the net when scaling it. If I use the code in the pip package everything works fine (0.0.11 seems to contain only code prior to the 7th of may). https://user-images.githubusercontent.com/54776552/198372984-f704cceb-8582-4bf9-bc23-c15ebb836b34.mp4

However I'm forking the repo (with the latest commit from august) because I need to change some internal code and noticed this problem.

https://user-images.githubusercontent.com/54776552/198373792-fd672ec7-708e-4ebe-b353-e291c8a591dd.mp4

Maybe someone can pinpoint the exact commit which causes this behaviour?

Code used:

class Test(Scene):
	def construct(self):
		# Make the Layer object
		l1 = Convolutional3DLayer(4, 2, 2)
		l2 = Convolutional3DLayer(5, 1, 1)
		l3 = Convolutional3DLayer(2, 3, 3)
		layers = [l1, l2, l3]
		nn = NeuralNetwork(layers)
		nn.scale(2)
		nn.move_to(ORIGIN)
		# Make Animation
		self.add(nn)
		#self.play(Create(nn))
		forward_propagation_animation = nn.make_forward_pass_animation(run_time=5, passing_flash=True)

		self.play(forward_propagation_animation)

fhnaumann avatar Oct 27 '22 18:10 fhnaumann