Koo
@eileencodes @flavorjones I have addressed the comments on this pull request. Thanks for your kind review! ❤️ Could you review it once again? but they seem unrelated to the changes....
@eileencodes I have made the changes based on your feedback. Thank you!
@jeremy At first, I looked at rails' implementation and thought it wouldn't be a huge burnden. (https://github.com/rails/rails/blob/4cfdcfef8eedb28a4e0f5d12fae80c2aade02a4c/activesupport/lib/active_support/cache/redis_cache_store.rb#L450-L461) But as you said, it might cause some performance issue. Then, how about...
@bb Thanks. I'll chery pick your commit and supplement documentation.
@bb I just cherry-picked your commit and add some test with documentation. Could you review it?
@balbesina. I just added expiration behavior in hash. I rarely used Redis's hash, I just forgot it 😅.
Hi, @dhh. Could you review this? I fixed https://github.com/rails/kredis/pull/133#issuecomment-1872184287's failing tests.
@roharon It'll be nice if we can set `expires_at`! Could you create PR for it?
Hi, @keithdoggett. I'm interested in this issue!
@skykongkong8 What do you think?