bromelia icon indicating copy to clipboard operation
bromelia copied to clipboard

Feature/addhost ip validation

Open hishamanver opened this issue 1 year ago • 0 comments

Changed:

  • fix install requires - should be a list object
  • support multihoming ip avp validation
  • Cleanup whitespaces (apologies for this, my editor does this automatically, happy to revert if required)

Why:

  • install dependencies is broken as there is a missing comma between pyyaml and pysctp
  • I am using bromelia as a client to test against a real HSS, the HSS returns 3 host addresses in the CEA, with the current code, the CEA verification fails as IP host validation accepts all three IP addresses thus making the checklist_mandatory_avps variable (https://github.com/heimiricmr/bromelia/blob/master/bromelia/process.py#L361) get a value of +2, these changes will set the ip valid counter only once and then finally tally up the mandatory avps

includes changes from https://github.com/heimiricmr/bromelia/pull/18

hishamanver avatar Dec 18 '23 08:12 hishamanver