heimdal icon indicating copy to clipboard operation
heimdal copied to clipboard

Support later Visual Studio releases better

Open fanc999-1 opened this issue 1 year ago • 5 comments

Hi,

This attempts to make the Heimdal builds against later Visual Studio better, by:

  • Updating include\config.w32 to define that stdint.h and inttypes.h (and the related types) are available, when Visual Studio 2010 or later and Visual Studio 2013 or later are used, respectively, since these headers are shipped with these versions of Visual Studio.
  • Update windows\NTMakefile.config and lib\roken\NTMakefile to reflect on the availability of stdint.h and stdbool.h, which are available since Visual Studio 2010 and Visual Studio 2013, repsectively. As a consequence, the compatibility headers for these headers that comes in lib\roken is not copied in cases where Visual Studio ships with them). This will fix builds that use Heimdal that is horribly broken when when the system inttypes.h is included, as things in the compatibility stdint.h will clash with the system's inttypes.h badly.
  • Update the makeinfo.exe call in windows\NTMakefile.w32 to instead use whatever that that is passed in throught envvars or the NMake command line.

With blessings, thank you!

fanc999-1 avatar Nov 01 '23 08:11 fanc999-1

It seems there are bigger issues with the windows build sadly.

abartlet avatar Nov 03 '23 01:11 abartlet

Hi. Can you post either here or raise a new issue listing the error(s) you have encountered? I would like to reproduce them locally. Thanks in advance.

sfhacker avatar Nov 13 '23 21:11 sfhacker

logs_3289.zip

The logs are available to me when logged in, but likely not guests. So I attach the zip file.

abartlet avatar Nov 13 '23 22:11 abartlet

image

nicowilliams avatar Jan 13 '24 07:01 nicowilliams

The problem may be this in windows/NTMakefile.w32:

{}.hin{$(INCDIR)}.h:
        $(CP) $< $@

which I think builds include/stdint.h from lib/roken/stdint.h. Where MSVC has its own stdint.h we must then not build our own stdint.h.

nicowilliams avatar Jan 13 '24 07:01 nicowilliams