heimdal
heimdal copied to clipboard
Support later Visual Studio releases better
Hi,
This attempts to make the Heimdal builds against later Visual Studio better, by:
- Updating
include\config.w32
to define thatstdint.h
andinttypes.h
(and the related types) are available, when Visual Studio 2010 or later and Visual Studio 2013 or later are used, respectively, since these headers are shipped with these versions of Visual Studio. - Update
windows\NTMakefile.config
andlib\roken\NTMakefile
to reflect on the availability ofstdint.h
andstdbool.h
, which are available since Visual Studio 2010 and Visual Studio 2013, repsectively. As a consequence, the compatibility headers for these headers that comes inlib\roken
is not copied in cases where Visual Studio ships with them). This will fix builds that use Heimdal that is horribly broken when when the systeminttypes.h
is included, as things in the compatibilitystdint.h
will clash with the system'sinttypes.h
badly. - Update the
makeinfo.exe
call inwindows\NTMakefile.w32
to instead use whatever that that is passed in throught envvars or the NMake command line.
With blessings, thank you!
It seems there are bigger issues with the windows build sadly.
Hi. Can you post either here or raise a new issue listing the error(s) you have encountered? I would like to reproduce them locally. Thanks in advance.
The logs are available to me when logged in, but likely not guests. So I attach the zip file.
The problem may be this in windows/NTMakefile.w32
:
{}.hin{$(INCDIR)}.h:
$(CP) $< $@
which I think builds include/stdint.h
from lib/roken/stdint.h
. Where MSVC has its own stdint.h
we must then not build our own stdint.h
.