pydevp2p icon indicating copy to clipboard operation
pydevp2p copied to clipboard

discovery: assert that pong and neighbour messages are signed by the expected identity

Open heikoheiko opened this issue 9 years ago • 3 comments

heikoheiko avatar Mar 01 '15 17:03 heikoheiko

This does not fix the failed detection at all. When I remove all of those checks and just run import pyelliptic everything works fine. I used macports to install openssl.

AFDudley avatar Apr 18 '15 19:04 AFDudley

this is a different #2 :) the commit is here: https://github.com/ethereum/pydevp2p/commit/b7b2a9f2ea0d0243840f812214ec235adabcd3d6

did you update pydevp2p?

heikoheiko avatar Apr 21 '15 10:04 heikoheiko

I did update it. The issue is the logic behind the import check is bad. It should first do the import pyelliptic, then check if the needed ciphers are there, then determine what to do about those missing ciphers. As the code stands, pyelliptic correctly finds my ciphers no problem, but your test does not.

AFDudley avatar Apr 21 '15 14:04 AFDudley