authLdap icon indicating copy to clipboard operation
authLdap copied to clipboard

Published 20 hours ago • verified publisher icon heiglandreas

Add multirole support

Open sbeus opened this issue 9 years ago • 3 comments

Existing authLdap code only supported users having a single role and would cause problems with other plugins (e.g. Members) that exploit WordPress' native support for multiple roles. This update should allow a user to belong to multiple roles and gracefully add roles based on LDAP group, if configured to do so. Simple tests using my specific use case have validated this change.

sbeus avatar Jan 11 '16 22:01 sbeus

Thank you for this PR!

From a first glance it looks like a great addition! But I'll have to dig through it and I'm sure I'll have the one or other question.

heiglandreas avatar Jan 13 '16 16:01 heiglandreas

Sorry, it became a bit lengthy.... But I'm through now :wink:

heiglandreas avatar Jan 13 '16 17:01 heiglandreas

Overall it looks like I was a bit hasty in my request. There are things that should clearly be changed about my initial set of updates. But it might be that we'll have to part ways simply based on our difference of opinion pointed out above relative to all WP or all LDAP but not both.

Thank you for your time.

sbeus avatar Jan 13 '16 23:01 sbeus