authLdap icon indicating copy to clipboard operation
authLdap copied to clipboard

UI: group/role mapping: Avoid repeating tutorial text

Open mdollinger opened this issue 4 years ago • 7 comments

Currently there are 3 lines of text after every group/role saying basically the same: grafik

For a bigger amount of wp-roles this can harm the overview. My suggestion is this: grafik

mdollinger avatar Feb 04 '21 07:02 mdollinger

Good idea! Thanks!

Can you create a PullRequest for that?

heiglandreas avatar Feb 04 '21 07:02 heiglandreas

Wow, you are really fast ;)

But sorry, no, i have no idea about this. For the screenshot i just did some HTML-manipulation locally in my browser.

The only help i can give is, that the width must be reduced again (ticket #195 ) to avoid a line break.

mdollinger avatar Feb 04 '21 08:02 mdollinger

:smile: Sometimes I'm fast.

Can you specify the issue with the width in #195 a bit more in detail? And possibly reopen it?

And I'll see to rearranging the stuff here :wink:

heiglandreas avatar Feb 04 '21 08:02 heiglandreas

How does this look like?

image

It's included with v2.4.9 ;-)

heiglandreas avatar Feb 04 '21 09:02 heiglandreas

Remove duplicate text: 100 % happyness

Regarding "shall match to" - see how it looks in my case. As soon the role names are a bit longer, line breaks occur. Also we carefully named our roles to clearly reveal their hierarchy:

  • Contributor
  • Contributor_accreditation
  • Contributor_coordination

This is lost with align right: grafik

My proposal would be to

  • either put the "shall match to" in a separate <td>-tag
  • or add it to the <td> with the <input>-tag (but here you would need to reduce the width eg. to 80% to avoid line break here)

mdollinger avatar Feb 04 '21 15:02 mdollinger

Does this look better?

image

image

heiglandreas avatar Feb 05 '21 06:02 heiglandreas

Das ist nicht nur better, das ist perfect ;)

mdollinger avatar Feb 05 '21 16:02 mdollinger

The modification has also been released, so I can close this.

heiglandreas avatar Aug 29 '23 09:08 heiglandreas