Android-country-picker icon indicating copy to clipboard operation
Android-country-picker copied to clipboard

Transparent space in png's

Open xsorifc28 opened this issue 8 years ago • 5 comments

Is there a reason as to why there is a transparent gap in the png's ?

Just wondering.

xsorifc28 avatar Mar 08 '16 19:03 xsorifc28

There is none but didn't see this as a problem at the time the lib was made. Do you need pngs with no gaps?

EKami avatar Apr 18 '16 09:04 EKami

It helps to predict the size better and adjust padding/margins. It is hard to take into account the transparency when using the icons outside of the country picker (I access the flag bitmaps elsewhere in my project).

xsorifc28 avatar Apr 20 '16 19:04 xsorifc28

Alright, having no gap in the pngs could indeed be helpful. I don't have the time for the moment to make the changes. Could you open up a PR with the removed gaps from the icons? I would be greatly appreciated.

EKami avatar Apr 27 '16 14:04 EKami

Do you have the icons as vectors or a script already? How did you generate the original ones?

xsorifc28 avatar Apr 28 '16 18:04 xsorifc28

The flags come from this repository

EKami avatar Apr 29 '16 16:04 EKami