hedy icon indicating copy to clipboard operation
hedy copied to clipboard

🧹 Clean code related to already removed features

Open jpelay opened this issue 7 months ago • 2 comments

Now that we were able to ship our new design for the adventures page, we can begin to remove from the code all of the features that we removed in version, most notably quizzes and parsons.

So, a summary:

  • It removes some of the html files that weren't needed. Some of them I kept, to maintain two endpoints called /adventures and /render-code. These two will be fixed when we get onto refactoring the teacher's page.
  • Removes all of the content for the quizzes and parsons.
  • Removes all mentions to quizzes and parsons in the code, except for the ones in the section for teachers, that one will be refactored shortly.
  • It moves the hour-of-code endpoint to the new design. In this vein, I also removed the capability to pass a subset of adventures through the URL, something that was not really used and is fixed through customizations.

This changes shouldn't affect the way the site works, since all of these was unused code! Still I'd like if someone could do a little round of testing around and check that things are indeed working :)

Fixes #6318

How to test

  • Everything should be working as expected

jpelay avatar Jun 06 '25 00:06 jpelay

Ah so good we are cleaning up the code base!! Love this @jpelay!

Felienne avatar Jun 13 '25 06:06 Felienne

@jpelay I tested al the obvious things and these work as normal 👍 Two things that did not work.

  • When the language of the teacher is not English, the code editor in the slides is not working.
  • If a teacher is grading a program of a student it is not possible to run the code because all the buttons are disabled. Scherm­afbeelding 2025-06-24 om 13 27 01

AnneliesVlaar avatar Jun 24 '25 11:06 AnneliesVlaar

Hello @AnneliesVlaar! Just fixed the errors you mentioned. However, there's still a bug related to translating code in the slides, but the bug has been around for at least a year. I think we can address that in its own PR.

Thanks for reviewing my code ;)

jpelay avatar Jul 02 '25 23:07 jpelay

However, there's still a bug related to translating code in the slides, but the bug has been around for at least a year.

Yes that is this issue Some slides can't use code editor, others do, depending on the page language #6123

AnneliesVlaar avatar Jul 04 '25 12:07 AnneliesVlaar

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Jul 04 '25 13:07 mergify[bot]