hedy
hedy copied to clipboard
💻 Updated language dropdown
Fixes #5426 Fixes #5459
How to test
- Log out and go to languages in the menu bar. Click the "help us translate" button
- Search for a language with the English name
I think it looks better in green. In yellow looks like something's wrong, or there's info missing(? So, green is better for me @Annelein
New designs: @gisellandrade @Felienne
New designs: @gisellandrade @Felienne
![]()
Maybe we can make it a little bit more explicit? Something like "Is your language missing? Help Hedy by adding it!"
@Felienne maybe then a tooltip would work better?
https://github.com/hedyorg/hedy/assets/48122190/84a8e6bb-5efb-485c-85c2-76d769611976
New designs: @gisellandrade @Felienne
For this i think the button should be next to the search input field!
As discussed:
- New issue for searching a language in English will also be added here #5459
- Change text to: 'Add your language'
- Remove button from profile page, only show it when not logged in
The tests are failing because of the iso639 import, i'm not sure why, if anyone can help out, would be great!
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).