hedy icon indicating copy to clipboard operation
hedy copied to clipboard

💻 Updated language dropdown

Open Annelein opened this issue 10 months ago • 7 comments

Fixes #5426 Fixes #5459

How to test

  1. Log out and go to languages in the menu bar. Click the "help us translate" button
  2. Search for a language with the English name

Annelein avatar Apr 17 '24 14:04 Annelein

I think it looks better in green. In yellow looks like something's wrong, or there's info missing(? So, green is better for me @Annelein

gisellandrade avatar Apr 17 '24 16:04 gisellandrade

New designs: @gisellandrade @Felienne

Screenshot 2024-04-18 at 12 07 19 Screenshot 2024-04-18 at 12 06 53

Annelein avatar Apr 18 '24 10:04 Annelein

New designs: @gisellandrade @Felienne

Screenshot 2024-04-18 at 12 07 19 Screenshot 2024-04-18 at 12 06 53

Maybe we can make it a little bit more explicit? Something like "Is your language missing? Help Hedy by adding it!"

Felienne avatar Apr 20 '24 14:04 Felienne

@Felienne maybe then a tooltip would work better?

https://github.com/hedyorg/hedy/assets/48122190/84a8e6bb-5efb-485c-85c2-76d769611976

Screenshot 2024-04-22 at 13 01 22

Annelein avatar Apr 22 '24 11:04 Annelein

New designs: @gisellandrade @Felienne Screenshot 2024-04-18 at 12 06 53

For this i think the button should be next to the search input field!

hasan-sh avatar Apr 23 '24 10:04 hasan-sh

As discussed:

  • New issue for searching a language in English will also be added here #5459
  • Change text to: 'Add your language'
  • Remove button from profile page, only show it when not logged in

Annelein avatar Apr 23 '24 14:04 Annelein

The tests are failing because of the iso639 import, i'm not sure why, if anyone can help out, would be great!

Annelein avatar Apr 24 '24 11:04 Annelein

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar May 06 '24 18:05 mergify[bot]

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar May 06 '24 19:05 mergify[bot]