hedy
hedy copied to clipboard
hedyorg
💻 update the footer with better ordering and new icons
Description: Create a kid-friendly footer that matches Hedy's platform vibe.
This PR related to discussion : https://github.com/hedyorg/hedy/issues/5381
How to test In the main part, as you scroll down, you'll see the footer has changed.
Checklist
- [X] Contains one of the PR categories in the name
- [X] Describes changes in the format above
- [X] Links to an existing issue or discussion
- [X] Has a "How to test" section
Thanks for the PR @El-Houssein-bedoui!
The test are failing since you have not added a translation:
Can you add translations in at least English to the po files (https://github.com/hedyorg/hedy/pull/5404/files#diff-852046eb47f474139974edf5e69ed9758f9fde82e1432c49d772b89aef354b37)
Also, where do the images come from? I want to make sure we are not infringing on anyone's rights!
The images are obtained from the website https://icons8.com/icons, where all PNG icons are provided for free download. However, there's uncertainty about whether we should attribute them. If attribution is required, we can acknowledge the source or seek alternative icons available for free use or you could draw them as you mentioned in previous discussion. ( I am sorry , I am still learning about all these stuff and thank you for your time)
@Felienne i find these photo that you can use without any attribution or credit "form https://uxwing.com" but the previous icons are surely better then these. So as I mentioned in the previous comment what do you think we should do ? Thank you.
@Felienne i find these photo that you can use without any attribution or credit "form https://uxwing.com" but the previous icons are surely better then these. So as I mentioned in the previous comment what do you think we should do ? Thank you.
Yeah I like the first ones better too but we have to be sure about what we can use. I think the best course of action is that I draw icons, then they'd be in our style and we can surely use then but I will not have tine to do so very soon, sorry!
@Felienne Hello ,I've been in touch with Icons8. I've purchased their subscription for $14 (no need to worry, I'll be utilizing them in future projects as well ...), granting me the right to use them without any attribution. Additionally, I've made some enhancements to the footer.
So, I believe we're all set for now. Thank you.
@Felienne Hey , I just want to know is there any other problem in my request so I could fix it . Thank you .
@Felienne Hey , I just want to know is there any other problem in my request so I could fix it . Thank you .
Hi @El-Houssein-bedoui! No there is nothing wrong, the action is now with me, I will draw the icons in our style. But I am busy the next two weeks with another important deadline so I will not be able to do it soon. Thanks for understanding and thanks for being patient!
@Felienne as I mentioned in the previous discussion , now I have the right to use the icons and it is like hedy's style so there is no need to draw them . But if you want to for sure . Thank you for your reply.
