hedy icon indicating copy to clipboard operation
hedy copied to clipboard

> The info text that appears by clicking the (i) button should be replaced.

Open hasan-sh opened this issue 10 months ago • 19 comments

          > The (i) text appears in a weird place:

The one I pasted above shows all the way at the bottom:

image

Should be above with the (i) I guess?

Originally posted by @Felienne in https://github.com/hedyorg/hedy/issues/5311#issuecomment-2029849480

hasan-sh avatar Apr 02 '24 13:04 hasan-sh

@gisellandrade can you take a look at this one too?

Annelein avatar Apr 03 '24 10:04 Annelein

What do you think about this?
@Felienne @hasan-sh @Annelein Image

gisellandrade avatar Apr 08 '24 19:04 gisellandrade

So it pops open if you click it and closes the second time you click? I could live with it, it would look more like our other designs then what it looks like now.

Annelein avatar Apr 09 '24 14:04 Annelein

Yep, just like that. That's how tooltips usually works

gisellandrade avatar Apr 09 '24 15:04 gisellandrade

@Felienne @hasan-sh what do you think? Then I can start implementing it

Annelein avatar Apr 10 '24 12:04 Annelein

Yes that looks like the right place! I am not sure we want the editor to go down, is that the suggestion? That type of moving stuff around in the UI I find a bit confusing.

Could we do modal that looks like this (not the colorfull kid-modal we have now), so this in a modal:

image

Somewhere close to the (i) icon?

I think we wanted to make a "adult facing" modal anyway, maybe we can start here?

Felienne avatar Apr 10 '24 13:04 Felienne

I'm not sure if I really like a modal. Because I can image it would be nice to have the info text visible while you're editing the adventure. Instead of having to open it every time you want to read it or don't understand something? Let me know if you understand what I mean?

What about an "information" slide that opens up on the right side of the screen, which doesn't overlap anything on the page, but just makes the page smaller? Kind of like the inspect, maybe a strange example haha, but I think visualizing something can be helpful:

https://github.com/hedyorg/hedy/assets/48122190/ac653106-03de-4041-86d0-aae27d85f48c

Annelein avatar Apr 10 '24 14:04 Annelein

I'm not sure if I really like a modal. Because I can image it would be nice to have the info text visible while you're editing the adventure. Instead of having to open it every time you want to read it or don't understand something? Let me know if you understand what I mean?

What about an "information" slide that opens up on the right side of the screen, which doesn't overlap anything on the page, but just makes the page smaller? Kind of like the inspect, maybe a strange example haha, but I think visualizing something can be helpful:

Screen.Recording.2024-04-10.at.16.10.27.mov

I love that idea!! I guess we can use it in other places too!

Felienne avatar Apr 10 '24 14:04 Felienne

@gisellandrade what do you think of this idea? And @hasan-sh curious what you think as well?

Annelein avatar Apr 10 '24 14:04 Annelein

I really like that idea, that you don't really need to open it, but the info is just there. Let me see how it would look like, and I'll put it over here. I'll be looking for some inspiration to this, because I'm not really sure if that's the best way to show the info!

gisellandrade avatar Apr 10 '24 15:04 gisellandrade

@gisellandrade I did mean that you would have to click something to open it, so that if you don't want to see it, you can also close it. Or did you get that part?

Annelein avatar Apr 10 '24 19:04 Annelein

@Annelein Yes, I got that part. But, the thing is that there's not like a lot of text, and half of the screen would be empty. I'm not sure if that would look good 😕

gisellandrade avatar Apr 10 '24 19:04 gisellandrade

@gisellandrade ah yes I get that! Great if you could look into it!

Annelein avatar Apr 10 '24 19:04 Annelein

I like it and I think we can implement this drawer in a generic way indeed @Felienne, such that it expects some html. It'd work similar to opening an issue in the board meeting of Github:

Screencast from 11-04-24 15:46:42.webm

The size we control so it doesn't need to be this wide. Also, we can gradually enhance it according to our needs.

hasan-sh avatar Apr 11 '24 13:04 hasan-sh

This is the best I could find, let me know what you think! image

gisellandrade avatar Apr 16 '24 02:04 gisellandrade

This is the best I could find, let me know what you think! image

I think it should rather be a menu that doesn't change the view width! What do you think about what i commented up? We could also simply show this info in a modal!!

hasan-sh avatar Apr 16 '24 11:04 hasan-sh

Lets discuss this in the meeting?

Annelein avatar Apr 16 '24 11:04 Annelein

This is the best I could find, let me know what you think! image

I think it should rather be a menu that doesn't change the view width! What do you think about what i commented up? We could also simply show this info in a modal!!

What do you think about this? Just for smalls screen, or maybe like using it always? so we don't have that problem with differents screens? @Annelein @hasan-sh

image

gisellandrade avatar Apr 16 '24 12:04 gisellandrade

@Felienne @gisellandrade @hasan-sh what do you think? (the top of the border is not visible in the screenvideo somehow)

https://github.com/hedyorg/hedy/assets/48122190/64ae40b4-5c38-4eaf-b1b8-87892bf1a041

Annelein avatar Apr 22 '24 11:04 Annelein

I think this way looks awesome! I really like it :)

gisellandrade avatar Apr 30 '24 00:04 gisellandrade