hedy icon indicating copy to clipboard operation
hedy copied to clipboard

💻 For teachers redesign

Open Annelein opened this issue 11 months ago • 11 comments

The design

Annelein avatar Mar 14 '24 10:03 Annelein

@jpelay @hasan-sh @Felienne @gisellandrade this is what it would look like! What do you think?

(If you open the slides, the public content container stretches with it, @jpelay @hasan-sh do you know how to solve this?)

Screenshot 2024-03-19 at 16 53 39

Annelein avatar Mar 19 '24 16:03 Annelein

@jpelay @hasan-sh @Felienne @gisellandrade this is what it would look like! What do you think?

(If you open the slides, the public content container stretches with it, @jpelay @hasan-sh do you know how to solve this?)

Screenshot 2024-03-19 at 16 53 39

I like this!!

Felienne avatar Mar 19 '24 16:03 Felienne

(If you open the slides, the public content container stretches with it, @jpelay @hasan-sh do you know how to solve this?)

Do you still need help? I like it from the picture too!

hasan-sh avatar Mar 20 '24 15:03 hasan-sh

Hi @Annelein so instead of solving this problem, which we could, why don't we follow the same style of the other "view ..." buttons? So, just create a table and when you click on view slides, that table appears and the user is navigated to it.

hasan-sh avatar Mar 21 '24 08:03 hasan-sh

Hi @Annelein so instead of solving this problem, which we could, why don't we follow the same style of the other "view ..." buttons? So, just create a table and when you click on view slides, that table appears and the user is navigated to it.

Hmm we could, I'm not sure if I like it as much, because the other tables include teacher actions, and the slides not so much. So its kind of something different I guess. But at the same time it would be consistent. @gisellandrade and @Felienne what do you think?

Annelein avatar Mar 21 '24 10:03 Annelein

Hmm we could, I'm not sure if I like it as much, because the other tables include teacher actions, and the slides not so much. So its kind of something different I guess. But at the same time it would be consistent. @gisellandrade and @Felienne what do you think?

I noticed that you display the slides inside the div where the view slides button is, what if you display them bellow like you do with the tables? You can keep the same styles as you do right now, but move them to their own spaces, so they don't modify the Slides' explanation div. Something like this!

image

jpelay avatar Mar 21 '24 14:03 jpelay

Hmm we could, I'm not sure if I like it as much, because the other tables include teacher actions, and the slides not so much. So its kind of something different I guess. But at the same time it would be consistent. @gisellandrade and @Felienne what do you think?

I noticed that you display the slides inside the div where the view slides button is, what if you display them bellow like you do with the tables? You can keep the same styles as you do right now, but move them to their own spaces, so they don't modify the Slides' explanation div. Something like this!

image

Thats exactly what @hasan-sh suggested, I just implemented the design from @gisellandrade. So if you guys think this would look best, I will implement it!

Annelein avatar Mar 21 '24 14:03 Annelein

Thats exactly what @hasan-sh suggested, I just implemented the design from @gisellandrade. So if you guys think this would look best, I will implement it!

Great mind thinks alike! haha What if we we keep the same idea of keeping the slides table in a separate the div, but make it the same width as the Slides explanation one?

jpelay avatar Mar 21 '24 14:03 jpelay

image

What do you think?

jpelay avatar Mar 21 '24 14:03 jpelay

@jpelay added it! So it's ready to be reviewed!

Annelein avatar Mar 21 '24 15:03 Annelein

@jpelay added it! So it's ready to be reviewed!

Awesome! Will review some other PRs and then come back to this one!

jpelay avatar Mar 21 '24 15:03 jpelay

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Apr 01 '24 11:04 mergify[bot]