hedy icon indicating copy to clipboard operation
hedy copied to clipboard

Remove Ace death code

Open jpelay opened this issue 2 years ago • 3 comments

After merging #4924 we know don't use Ace for any editor on Hedy, meaning that we won't be maintaining it going forward. Therefore, we're going to remove it, which entails removing:

  • ace-editor.ts
  • ace related styles
  • ace plug-ins
  • highlight files related to ace

We think it's still important to maintain the editor abstraction, so even if we remove ace, it doesn't mean we will be solely dependent on CodeMirror (although I do hope we don't have to change it again in the future!).

jpelay avatar Jan 02 '24 16:01 jpelay

(although I do hope we don't have to change it again in the future!).

Hahaha, SAME!

Felienne avatar Jan 02 '24 16:01 Felienne

Hi @jpelay! Maybe you can do this together with @Annelein so that she gets to know the editor side a bit more? I am sure if you give her a small start, she can do the heavy lifting afterwards

Felienne avatar Mar 19 '24 13:03 Felienne

Sure! @Annelein let me know if you want to handle this by having a one to one, or maybe you want to start yourself and request pointers if you have any doubts?

jpelay avatar Mar 19 '24 15:03 jpelay

@jpelay a one to one would be great, what about tomorrow?

Annelein avatar Mar 27 '24 12:03 Annelein