hedy icon indicating copy to clipboard operation
hedy copied to clipboard

📜 Teacher manual does not use {} around all keywords

Open Felienne opened this issue 1 year ago • 2 comments

This issue is part of the root cause of #4134. The manual cannot use localized keywords because a lot of the content does not use curlies around keyword.

So @MarleenGilsing (who opened #4134 haha) if you want to move this forward, we need to clean up the yamls. For example:

Here you see an example of a few codes where some do and some don't use curlies:

image (https://github.com/hedyorg/hedy/blob/f10527506b6468131e03e1db89a2f48d6bbee940/content/pages/en.yaml#L465)

So step one is to add them, and ideally also in other languages (I know that wil be a lot of work and not fun...)

And, it will not always be possible to do localize, for example, broken keywords like printt cannot be translated:

image

But I guess a teacher will understand.

Felienne avatar Dec 13 '23 09:12 Felienne

Maybe this would also be a good task for @SabinaChita? I will let the two of you sync on that!

Felienne avatar Dec 13 '23 09:12 Felienne

Hi @SabinaChita!

The relevant content for the teacher manual starts here: https://github.com/hedyorg/hedy/blob/04c9797008a569793fe56abfd76d7fda717943d2/content/pages/en.yaml#L377

So it is a matter of reading all the code lines and adding curlies where needed.

If we want to do it really nicely, we also do it in other languages, but let's start with English for now!

Felienne avatar Jan 19 '24 10:01 Felienne

This was fixed by #5167

jpelay avatar Aug 13 '24 18:08 jpelay