hedy icon indicating copy to clipboard operation
hedy copied to clipboard

Published 20 hours ago • verified publisher icon hedyorg

[BUG FIX] 'error or empty' achievement can be achieved again

Open TiBiBa opened this issue 2 years ago • 2 comments

Description This PR fixes an issue where we dependent on an unused variable in the TypeScript code for the 'error or empty' achievement check. Therefore it was never reached; and users where unable to achieve it. Thanks to an observant Hedy user (Kuno) this bug was noted.

Fixes No related issue.

How to test Make sure you have an account that doesn't have the 'error or empty' achievement yet. Create a program without an input but that is an actual program! For example, by using an ask without an echo in level 1. Verify that the achieved is received.

TiBiBa avatar Oct 11 '22 21:10 TiBiBa

Hi @TiBiBa

I have not yet managed to get the achievement again :(

image

Felienne avatar Oct 13 '22 16:10 Felienne

Hi @TiBiBa

I have not yet managed to get the achievement again :(

image

Weird! It should be working (tested it on a new account as well), will take another look at this later today.

TiBiBa avatar Oct 13 '22 16:10 TiBiBa

Found it! It was broken due to the routing re-structuring. The achievement push from the front-end was made to the /achievements route. But due to the re-structuring the route was not found as /achievements/achievements. This is fixed and we also fixed a minor issue on a smaller screen where the error/warning box of the code editor would overlay on the achievement pop-up.

TiBiBa avatar Oct 18 '22 15:10 TiBiBa