hedy icon indicating copy to clipboard operation
hedy copied to clipboard

[CONTENT] verification of the use of double quotation marks

Open thjazi39 opened this issue 2 years ago • 4 comments

In case the PR #2249 would be accepted, the quizzes would have to be checked to ensure that the answers are correct. And this in all languages.

There is this question that will have to be corrected, but there are surely others. image

thjazi39 avatar Mar 22 '22 10:03 thjazi39

Just to let you know I am looking at the fix for this issue.

Rezwin avatar May 24 '22 06:05 Rezwin

I can see the options of this question has been changed on main branch.

2:
         question_text: "Which code uses the proper quotation marks?"
         mp_choice_options:
         -   option: |
                 ```
                 {print} `hello`
                 ```
             feedback: "This quotation mark is skewed, you need a straight one."
         -   option: |
                 ```
                 {print} 'hello'
                 ```
             feedback: "Correct"
         -   option: |
                 ```
                 {print} hello
                 ```
             feedback: "There are no quotation marks here!."
         -   option: |
                 ```
                 {print} ,hello,
                 ```
             feedback: "This is a comma, you need quotation marks."
         correct_answer: "B"
         hint: "Pick the right quotation marks."
         question_score: '10'

However the changes are not yet visible on the website.

Screenshot 2022-07-11 at 16 31 15

Does anyone know if the changes has been already deployed to the main server ?

If the changes are already deployed, I guess the problem could be with rendering of backtick.

Rezwin avatar Jul 13 '22 12:07 Rezwin

Ha @Rezwin! I missed your comment sorry, I was on vacation.

Firstly, you can always see on https://hedycode.com/version what commits have been deployed!

I can also confirm the change is indeed live:

image

But indeed ``` does not seem to be a good choice as it does not render properly, so either @TiBiBa should maybe make a change to the code block rendering here or you should change the option. Would it be hard to change the rendering?

Felienne avatar Jul 23 '22 18:07 Felienne

Ha @Rezwin! I missed your comment sorry, I was on vacation.

Firstly, you can always see on https://hedycode.com/version what commits have been deployed!

I can also confirm the change is indeed live:

image

But indeed ``` does not seem to be a good choice as it does not render properly, so either @TiBiBa should maybe make a change to the code block rendering here or you should change the option. Would it be hard to change the rendering?

Thanks @Felienne

I opened https://github.com/Felienne/hedy/pull/3102 to fix the issue.

Rezwin avatar Jul 23 '22 21:07 Rezwin

This issue was a bit derailed I think by the backtick issue and now I am not sure if the quizzes are all updated (removing the " as option) Could you check @jpelay

Felienne avatar Oct 18 '22 15:10 Felienne