nix-bash-completions icon indicating copy to clipboard operation
nix-bash-completions copied to clipboard

Published 20 hours ago • verified publisher icon hedning

Avoid completion conflict with modern 'nix' CLI

Open bjornfor opened this issue 2 years ago • 7 comments

[This supersedes https://github.com/hedning/nix-bash-completions/pull/21.]

Upstream nix (>=2.4) has completion for the modern 'nix' CLI, and the completion provided by nix-bash-completions cause a conflict that breaks completion:

$ nix build<TAB_TAB> # line gets erased

Fix it by not installing completion for 'nix', which lets Nix handle its own completions.

As a side effect, this breaks/removes completion for the experimental 'nix' commands in nix<=2.3, but hopefully there is no real use case for that anymore as even the latest NixOS version use nix>=2.8.

Fixes https://github.com/hedning/nix-bash-completions/issues/20.

bjornfor avatar Jun 07 '22 14:06 bjornfor

Ping?

bjornfor avatar Jun 23 '22 17:06 bjornfor

Ping. NixOS 22.05 has Nix 2.8.1, which means completing modern nix ... is now broken. It would be great to have this PR landed and release a new version of nix-bash-completions :-)

bjornfor avatar Jul 04 '22 18:07 bjornfor

@hedning: friendly ping

bjornfor avatar Nov 25 '22 09:11 bjornfor

@ncfavier: friendly ping?

bjornfor avatar Dec 22 '22 09:12 bjornfor

I want this as much as you do, but the maintainer is unresponsive. Perhaps it is time to add this patch in nixpkgs.

ncfavier avatar Dec 22 '22 09:12 ncfavier

I want this as much as you do, but the maintainer is unresponsive. Perhaps it is time to add this patch in nixpkgs.

Oh, I guess I assumed you had commit rights based on this comment, and I realized I hadn't pinged you in this PR.

Ok, nixpkgs next.

bjornfor avatar Dec 22 '22 10:12 bjornfor

https://github.com/NixOS/nixpkgs/pull/207224

ncfavier avatar Dec 22 '22 10:12 ncfavier