vscode-drawio icon indicating copy to clipboard operation
vscode-drawio copied to clipboard

`title` for `customColorThemes` setting

Open lasssim opened this issue 3 years ago • 6 comments

As documented here [1], customColorSchemes can have a title attribute that is used as a tooltip in the format panel of the editor.

It was not working when I added it to the configuration of your vscode plugin, so I attempted to add it (see https://github.com/lasssim/vscode-drawio/commit/7759532cd943b3a1f458c073b4cda4a261d7cbeb). It still is not working.

What I noticed, though is, that the editor in the plugin behaves differently from the desktop editor.

The tooltip with the configured title is shown on the desktop editor, but missing on the plugin editor. The setting was in both cases this:

			{
				"title": "Kind of pink",
				"fill": "#00ff00",
				"stroke": "none",
				"font": "#ffff00",
				"gradient": "#0000ff",
			}
Desktop (expected behavior) Plugin (missing tooltip)
image image

Am I missing something, or do you see an obvious mistake I made? Is there a way to dump or see the current configuration of the plugin editor?

[1] https://www.diagrams.net/doc/faq/configure-diagram-editor

lasssim avatar Oct 14 '21 13:10 lasssim

Can you post your full (draw.io related) settings?

I don't see anything obvious that is missing.

hediet avatar Oct 14 '21 14:10 hediet

I was collecting data for my answer and realized, that the desktop app I used was version 15.something.

The plugin uses 14.8.0. So I checked the changelog of drawio and found out that this feature was added in 14.9.5 (https://github.com/jgraph/drawio/blob/dev/ChangeLog#L342)

I guess there is a reason why you didn't switch to a newer version of drawio. Or is it easy/safe to move to a newer version?

lasssim avatar Oct 14 '21 19:10 lasssim

Ok, just tried it with version 14.9.9 (the latest version of 14.x.x) in the plugin. Guess what, it works.

lasssim avatar Oct 15 '21 06:10 lasssim

Please take a look at https://github.com/hediet/vscode-drawio/pull/273 where I made related changes

lasssim avatar Oct 15 '21 08:10 lasssim

Thank you for accepting my PR. I think you can close the issue.

Wouldn't the latest settings changes make for a nice release? I'd be grateful to see them in a release, so I can use them with my clients.

lasssim avatar Oct 20 '21 08:10 lasssim

Wouldn't the latest settings changes make for a nice release? I'd be grateful to see them in a release, so I can use them with my clients.

Sure! Please add an entry to the changelog (with -alpha suffix, see history) and it will be released automatically.

hediet avatar Oct 20 '21 08:10 hediet