Henning Dieterichs

Results 576 comments of Henning Dieterichs

Actually, this should be falsy to work for arbitrary json: https://github.com/hediet/vscode-debug-visualizer/blob/2453c8bf9c4a6fb46459737e8165ce5a961167c2/extension/src/VisualizationBackend/GenericVisualizationSupport.ts#L68 The variables reference was an external contribution and it works nicely in Python. I suggest to first try `parseEvaluationResultFromGenericDebugAdapter`...

If you like, please file a PR!

What did you select as Data Extractor? Can you show a screenshot?

> It is Java code. I thought until now that if no Data Extractor is used, then the expression is interpreted directly as a JSON string. I got a PR...

> In the JSON source a quotation mark is displayed. Maybe the visualizer can't handle the fact that the Java debugger returns a " as the first character. The extension...

Instead of ``` y "{"kind":{"graph":true},"nodes":[{"id":"1"},{"id":"2"},{"id":"3"}],"edges":[{"from":"1","to":"2"},{"from":"2","to":"3"}]}" coder: 0 hash: 0 value: byte[120]@23 ``` If would have expected the output to be just this: ``` y "{"kind":{"graph":true},"nodes":[{"id":"1"},{"id":"2"},{"id":"3"}],"edges":[{"from":"1","to":"2"},{"from":"2","to":"3"}]}" ```

Probably, the extension should first try to decode is as JSON string and only if that fails use `variablesReference`. I'm open for a PR, but try to look at it...

Awesome ;) You can find them [here](https://github.com/hediet/visualization/tree/master/visualization-bundle/src/visualizers). Reach out if you have questions!

I just added some documentation [here](https://github.com/hediet/visualization/blob/master/visualization-bundle/README.md#implementing-new-visualizations).

I think the grid visualization might suffer from performance for large matrices. But yeah, the grid visualizer might be a replacement for this.