Maksym Kryvchun

Results 41 comments of Maksym Kryvchun

implemented in https://github.com/hedhyw/json-log-viewer/pull/85

possible fields can be known from [the configuration](https://github.com/hedhyw/json-log-viewer/blob/0172be3bd0977e01d924851111b3fa427036d38e/internal/pkg/config/config.go#L21)

@Mihai22125 Hey! Do you still need this feature?

> Hi I want to work on it. Hi! Thank you. > Can you please explain what do you mean by _Show the list of fields to sort by_ ?...

> I might need some help also in understanding the flow of code properly. - Clicking hotkeys ("O"/"F6") on `StateLoaded`, `StateFiltered` should open a dialogue to select a field to...

> Can you take a look at it and see if I am following the right approach? https://github.com/SpoonBuoy/json-log-viewer/tree/spoon looks right, but I'm not sure we need `StateSorted`, we can save...

@SpoonBuoy do you still need this feature?

Hello, thanks for the feature request! It's a good idea with a config flag! - `jlv -c custom_config.json app.log` - `jlv --config custom_config.json app.log` We can pass it to https://github.com/hedhyw/json-log-viewer/blob/d1b9829422eb783b62e405061ea73423b61086b5/cmd/jlv/main.go#L41

It's a good improvement and very easy to implement, because `ParseLogEntry` has a config. Thank you!