haskell-hedgehog icon indicating copy to clipboard operation
haskell-hedgehog copied to clipboard

Published 20 hours ago • verified publisher icon hedgehogqa

Only build-depend on fail and semigroups with ancient GHC

Open clinty opened this issue 6 years ago • 4 comments
trafficstars

clinty avatar Sep 14 '19 20:09 clinty

Is this causing you a problem? fail and semigroups do that switch internally to make sure the right version is exported afaik

jacobstanley avatar Sep 16 '19 20:09 jacobstanley

We don't have empty packages in Debian so any uses of them (fail, nats, bytestring-builder, etc.) need to be patched out which leads to a lot of wasted labor that needs to be repeated on every package upgrade. Things like semigroups are okay because they're not completely empty, but since you're not actually using Data.Semigroup.Generic there's no real point in including it either.

clinty avatar Sep 16 '19 22:09 clinty

We don't have empty packages in Debian so any uses of them (fail, nats, bytestring-builder, etc.) need to be patched out

What's the current procedure for working around this issue? I don't have Debian around to try this, but both builds are green (just had to re-run the AppVeyor one).

If we decide to merge this, at least the dependencies should be aligned with all the others :mag_right:, like so:

image

image

moodmosaic avatar Nov 14 '19 10:11 moodmosaic

Here's an example of how we work around fail in the repline package: https://sources.debian.org/src/haskell-repline/0.2.1.0-2/debian/patches/no-fail/

(cf. https://github.com/sdiehl/repline/issues/14)

clinty avatar Nov 14 '19 15:11 clinty