react-client icon indicating copy to clipboard operation
react-client copied to clipboard

Try to move external-types

Open DerMolly opened this issue 5 years ago • 1 comments

We should try to move as much as possible from src/external-types to either the projects repos or DefinetlyTyped.

  • [x] abcjs PR there
  • [x] emoji-mart
    • unnecessary as of #620
  • [x] flowchart.js PR there | PR here
  • [ ] markdown-it-abbr
  • [ ] markdown-it-deflist
  • [ ] markdown-it-emoji
  • [ ] markdown-it-footnote
  • [x] markdown-it-front-matter PR there
  • [ ] markdown-it-imsize
  • [ ] markdown-it-ins
  • [ ] markdown-it-linkify
  • [ ] markdown-it-mark
  • [ ] markdown-it-mathjax PR there
  • [x] markdown-it-plantuml PR there
  • [ ] markdown-it-regex PR there
  • [ ] markdown-it-sub PR there
  • [ ] markdown-it-sup PR there
  • [x] markdown-it-toc-done-right PR there | PR here
  • [x] markmap-lib
    • afaik this is not possible to remove as it is needed to function correctly, but it's a reexport anyway so maybe that is okay-ish.

DerMolly avatar Oct 09 '20 07:10 DerMolly

Please be sure, that

  • Every PR includes EVERY possible type, signature and option! For our project it's okay to just use what we need. But if you provide these types to the original project then add everything. Otherwise they're useless because other devs have to complete them for their projects.
  • You use function instead of lambda consts, because this is something that only we do.

mrdrogdrog avatar Oct 13 '20 14:10 mrdrogdrog

Most of these were attempted, but many repos did adopt this unfortunatly

DerMolly avatar Nov 22 '22 21:11 DerMolly