XenonRecomp icon indicating copy to clipboard operation
XenonRecomp copied to clipboard

Add automatic builds for Linux/Windows

Open Sakimotor opened this issue 10 months ago • 7 comments

First time I do this so I don't know if my workflow is any good, and I did unashamedly cross-reference some github template examples with AI coding tools but after testing them the artifacts seem to run like intended.

Sakimotor avatar Mar 03 '25 11:03 Sakimotor

Neat, but you might want to add the GitHub release step so it's shown in the Releases section.

yell0wsuit avatar Mar 04 '25 14:03 yell0wsuit

Neat, but you might want to add the GitHub release step so it's shown in the Releases section.

Hmmmm I wonder if I've got it right, the if check might be futile but I don't see what other name I could give to the releases

Sakimotor avatar Mar 04 '25 20:03 Sakimotor

For future reference, instead of submitting a PR with 19 commits with the same title, you can always git rebase and squash them into a single commit. It looks nicer and easier to follow if the changes are simple/in a single file.

E.X. New commit making changes to same file on top of another commit git rebase -i HEAD~2 (2 being the number of commits you're rebasing on from current HEAD) will open text editor and you can put a s to squash the new one into the old, then just git push -f to force it over the old history on github.

pnill avatar Mar 05 '25 11:03 pnill

You can also just squash-merge the PR to clean up the history while merging it.

halotroop2288 avatar Mar 06 '25 04:03 halotroop2288

For future reference, instead of submitting a PR with 19 commits with the same title, you can always git rebase and squash them into a single commit. It looks nicer and easier to follow if the changes are simple/in a single file.

E.X. New commit making changes to same file on top of another commit git rebase -i HEAD~2 (2 being the number of commits you're rebasing on from current HEAD) will open text editor and you can put a s to squash the new one into the old, then just git push -f to force it over the old history on github.

I will look into that, thanks. I usually give a minimal description to my commits, but this time I used the website's API so it ends up looking pretty messy and not very informative

Sakimotor avatar Mar 06 '25 10:03 Sakimotor

I also don't really want GitHub releases to be created

Then where are you going to upload nightlies? Because GitHub Actions storing artifacts for a short period of time and requiring a sign-in to download is kinda cringe.

halotroop2288 avatar Apr 12 '25 21:04 halotroop2288

The recompiler is incomplete and will most likely require the user to make modifications to it. I don't see much point to providing prebuilt binaries.

blueskythlikesclouds avatar Apr 12 '25 21:04 blueskythlikesclouds