XenonRecomp icon indicating copy to clipboard operation
XenonRecomp copied to clipboard

Added extra vpkd3d128 cases (5,2,2 and other 0,1)

Open JillianTo opened this issue 9 months ago • 1 comments

For some reason the whitespace doesn't show correctly in Github but the rawfile has the right whitespace. Used with the NG2_MoreInstructions branch because it's needed for NG2. Verified against Xenia with some vpkd3d128(5,2,2) calls in NG2, not tested when using without additional NG2/BBB instructions and simde. Uploaded PR for visibility

JillianTo avatar Mar 19 '25 16:03 JillianTo

The whitespace problem is probably due to mixing tabs and spaces in the same file, GitHub displays these with different widths.

BTW, I didn't know this when creating XenonRecomp but fmt allows you to specify an argument index inside the curly braces, so you can use that to remove the unnecessary repeating temp() calls like:

println("displaying first argument multiple times: {0} {0} {0}, second arg multiple times: {1} {1} {1}", arg0, arg1); 

blueskythlikesclouds avatar Mar 19 '25 16:03 blueskythlikesclouds

Tested newest commit and outputted PPCs are equivalent to what they were before. Whitespace is fixed in addition to allowing for shift inputs other than 2

JillianTo avatar Apr 04 '25 15:04 JillianTo