UnleashedRecomp icon indicating copy to clipboard operation
UnleashedRecomp copied to clipboard

Add hidden DisableDPadAsAnalogInput option

Open Refragg opened this issue 9 months ago • 13 comments

This PR adds a configuration entry in the 'Codes' section named DPadAsAnalogInput allowing someone to enable or disable the movement of Sonic / the world map cursor using the directional pad buttons. This default behavior on the original game was to not move Sonic / the world map cursor when the dpad was used, I thought it would be good to let people choose this if they want. Let me know if anything else needs to be changed.

Refragg avatar Mar 02 '25 16:03 Refragg

The d-pad controls are added into the recompilation as an enhancement and are purposefully not exposed on a toggle.

DeaTh-G avatar Mar 02 '25 16:03 DeaTh-G

I understand, maybe this option could still exist while staying on by default? I know that it personally does bother me a bunch, it can be annoying for some tricks in the game.

Refragg avatar Mar 02 '25 17:03 Refragg

What tricks can it be problematic with? Does it get in the way of some pausing tricks or similar?

blueskythlikesclouds avatar Mar 02 '25 17:03 blueskythlikesclouds

It's probably not things that a casual player would run into but for example with speedrunning, there is one notorious trick named XP glitch where the dpad and the left stick are used at the same time and it does not really play nicely.

Refragg avatar Mar 02 '25 17:03 Refragg

Oh okay, that's valid.

blueskythlikesclouds avatar Mar 02 '25 17:03 blueskythlikesclouds

Okay, I've inverted the option so that the dpad movement is enabled by default and I changed it's name to DisableDPadAsAnalogInput instead.

Refragg avatar Mar 02 '25 18:03 Refragg

Right, I didn't touch these as I wasn't sure what they were doing. Also, I don't have access to a DS4 controller so I won't be able to test this. Either way, I'll get to this later today.

Refragg avatar Mar 03 '25 06:03 Refragg

Alright, again, I can't test these changes as I don't have a DS4 and I don't know what SpaceHurrier is but i think that's what you wanted me to add, right?

Refragg avatar Mar 03 '25 16:03 Refragg

PostureSpaceHurrierDPadSupport is for the Gaia Colossus posture.

hyperbx avatar Mar 03 '25 16:03 hyperbx

Ah alright, that makes more sense now, thanks for that information.

Refragg avatar Mar 03 '25 16:03 Refragg

Interestingly, from my testing, it looks like those space hurrier hooks might not even be needed. If I remove their entire code, when the dpad analog input is enabled, Gaia Colossus still moves. He doesn't move when the analog input is disabled regardless of whether the original hook code runs or not. Unless the space hurrier posture doesn't actually mean the movement of Gaia Colossus?

Refragg avatar Mar 03 '25 17:03 Refragg

They're needed for the leaning animations.

hyperbx avatar Mar 03 '25 17:03 hyperbx

Fair enough, I didn't quite understand it i suppose, apologies for my lack of knowledge on all this 😅

Refragg avatar Mar 03 '25 18:03 Refragg

Hi, as a former unleashed runner I gotta say that moving sonic with the dpad buttons is very annoying to me as it makes some speedrun tricks very hard to perform. I know it was added as an enhanced to the game, but I'd love if we could disable it. So my question is: is this going to be added in the future? Please do it or I will need to buy a xbox controller (I have a ps5 controller)

raixstailo avatar Mar 05 '25 02:03 raixstailo

This PR adds the ability to disable D-Pad support using a HMM code, please wait for v1.0.2.

hyperbx avatar Mar 05 '25 02:03 hyperbx

Thank you so much.

raixstailo avatar Mar 05 '25 02:03 raixstailo

Thank you for the merge! I just have one last question, do you want me to make a PR to the HMMCodes repository to add the code or do you guys prefer to handle that yourselves?

Refragg avatar Mar 06 '25 09:03 Refragg