UnleashedRecomp icon indicating copy to clipboard operation
UnleashedRecomp copied to clipboard

Fix sound for native Linux build

Open xboxones1 opened this issue 8 months ago • 6 comments

Fixes https://github.com/hedge-dev/UnleashedRecomp/issues/535

xboxones1 avatar Apr 07 '25 04:04 xboxones1

Tested the existing compiled executable with the dependencies in this fix installed, makes no changes to issue, as they are -dev libraries, I'd imagine compiling with them pre-installed could give different results, I've been unable to successfully compile it at all on Linux Mint, has problems with ssl build components. Happy to test if someone builds with the dependencies in place.

But yes Mint uses pulse or pipewire depending on the version or other packages you've installed, so it may make a difference in my case.

LiveFreeDead avatar Apr 08 '25 00:04 LiveFreeDead

@blueskythlikesclouds, How long does it take to consider adding three dependencies? It's been almost half a year now. You haven't even run the artifacts build for testing.

xboxones1 avatar Aug 16 '25 05:08 xboxones1

What's with the demanding tone? I've been taking a break from the project so I'm very slow at checking PRs, it took me half a year to merge the macOS PRs too. Not to mention we have perfectly functional Linux builds provided in Flatpak format so this isn't that urgent.

blueskythlikesclouds avatar Aug 16 '25 05:08 blueskythlikesclouds

You misunderstand me, I'm not demanding anything. I thought it wouldn't take long to add three dependencies. There's no code to review here, like with adding macOS support.

xboxones1 avatar Aug 16 '25 06:08 xboxones1

Sorry, was not in a good mood, I apologize for my tone.

The CI is currently broken and does not work for external PRs, but I can add the branch to the main repository to test if it got fixed.

blueskythlikesclouds avatar Aug 16 '25 06:08 blueskythlikesclouds

However you find it most convenient. Before creating the pull request, I tested it on many distributions with different sound servers, and it works.

xboxones1 avatar Aug 16 '25 08:08 xboxones1