UnleashedRecomp icon indicating copy to clipboard operation
UnleashedRecomp copied to clipboard

MSAA Affects the Water Distortion Shader when it shouldn't

Open Windowslover1234 opened this issue 8 months ago • 6 comments

Validation

  • [x] I have checked the Issues page to see if my problem has already been reported
  • [ ] I have confirmed that this bug does not occur in the original game running on original Xbox 360 hardware

If you have DLC installed, please specify which ones you have.

  • [x] Apotos & Shamar Adventure Pack
  • [x] Chun-nan Adventure Pack
  • [x] Empire City & Adabat Adventure Pack
  • [x] Holoska Adventure Pack
  • [x] Mazuri Adventure Pack
  • [x] Spagonia Adventure Pack

If you have mods enabled, please specify which ones you have.

Optional Improvements Refined Sonic Controls Generic QTE Buttons

If you have codes enabled, please specify which ones you have.

All Fixes, (Unleash out of Control Drain, Eggmanland event gallery transition) Allow Unleash Cancel Save Score at Checkpoints Use Official Title on Title Bar Disable Auto Save Warning and DLC Icon Toggle UI with F8

Describe the Bug

It Seems as though MSAA interacts with the water when it shouldn't.

Image

Steps to Reproduce

  1. Enable MSAA
  2. Go to any level with water
  3. Position the camera so an object is rendered above of the water

Expected Behavior

Water Shader isn't affected by MSAA

Image

Footage

It might not show up well, it is very subtle

https://github.com/user-attachments/assets/e28069ad-ba28-4526-904f-372375238fa9

System Specifications

Renderer: Vulkan (Might Matter, not sure) CPU: i3 4160 GPU: r9 280 3GB (1150 MHz OC) GPU Driver: Radeon 22.6.1 (Latest) OS: Windows 10 22H2 Version: 1.0.3

Additional Context

I am unable to test DirectX 12 as my GPU doesn't support Shader Model 6.0 or full DX12 (11.1)

Video Settings (Probably Doesn't Matter):

AspectRatio = "16:9"
ResolutionScale = 1
Fullscreen = true
VSync = false
TripleBuffering = "Auto"
FPS = 241
ShowFPS = true
MaxFrameLatency = 2
Brightness = 0.29999998
AntiAliasing =  Both 8x MSAA and None
TransparencyAntiAliasing = false
AnisotropicFiltering = 16
ShadowResolution = "4096"
GITextureFiltering = "Bicubic"
DepthOfFieldQuality = "Auto"
MotionBlur = "Off"
XboxColorCorrection = false
CutsceneAspectRatio = "Unlocked"
UIAlignmentMode = "Edge"

[Update]
LastChecked = 1743811810

Windowslover1234 avatar Apr 05 '25 01:04 Windowslover1234

This report is very hard to understand and compressed video footage is a really bad choice to show what you're talking about. I don't really understand what "interacts with the water when it shouldn't" means and what exactly you're basing this on.

DarioSamo avatar Apr 05 '25 02:04 DarioSamo

What?

blueskythlikesclouds avatar Apr 05 '25 07:04 blueskythlikesclouds

I don't really understand how to explain it. When there is an actor that isn't affected by the water shader, the AA looks like it affects it, and a thin line around the object is rendered and affected by the water shader. I'll remove the video and replace it with two screenshots when I have access to my computer again, which is probably what I should have done in the first place.

Windowslover1234 avatar Apr 05 '25 16:04 Windowslover1234

The distortion will make outlines appear due to MSAA having more than one depth sample, yes. But this happens on original hardware as well.

blueskythlikesclouds avatar Apr 05 '25 16:04 blueskythlikesclouds

Had a feeling it was, I'm not entirely sure how to add issue types (or if it's a contributor only thing), so feel free to place the "Original Game Bug" type on here.

Windowslover1234 avatar Apr 05 '25 16:04 Windowslover1234

The distortion will make outlines appear due to MSAA having more than one depth sample, yes. But this happens on original hardware as well.

Some sample images from real hardware showing the described the same artifcating Image Image Image Image

DeaTh-G avatar Apr 13 '25 05:04 DeaTh-G