Hector Hernandez

Results 177 comments of Hector Hernandez

@carlpett if you return true the Incoming Request will be ignored, and if you return false it will generate a Span. ` let httpConfig: HttpInstrumentationConfig = { ignoreIncomingRequestHook: (req) =>...

@GravlLift looks like contracts are outdated here, tags should be an object like this `{[propertyName: string]: string }`

@ChuckJonas can you share docs you are referring to? I'm not really familiar with Diagnostic-Id property

Only changed references to the package, all the code still remains under "./experimental/packages/opentelemetry-sdk-metrics-base" moving the code will create a huge amount of files changes making it really hard to review,...

@legendecas my main concern was that it was going to be harder to review and easier to miss something, people already review the actual package references so we should be...

@dyladan @vmarchaud I changed the files path as well in this PR as @legendecas suggested, please take another look.

@dyladan let me know if there is something preventing this one to be merged so I can work on it.

@ArtemisMucaj you should be able to get telemetry from MongoDB 4 using newer beta version of this SDK, more info [here](https://github.com/microsoft/ApplicationInsights-node.js/tree/beta#readme)

@maorleger JS OTel is currently working on supporting new semconv, work is being tracked [here](https://github.com/open-telemetry/opentelemetry-js/issues/4572), currently exporters do not support latest semantic convention, including Azure Monitor one, I will sync...

@lmolkova Created following [issue](https://github.com/Azure/azure-sdk-for-js/issues/29033) to track on exporter side, we are waiting for @opentelemetry/semantic-conventions to have latest attributes, we will update when they are available.