koolo icon indicating copy to clipboard operation
koolo copied to clipboard

Auto equip

Open CarlPoppa1 opened this issue 10 months ago • 11 comments

Heavily borrowed from kolbot-soloplay This only supports softcore sorc with an act 2 merc.

You need #684 for this to work properly.

Known issues:

  • Some stats aren't being read (e.g Decrepify on hit on Reapers Toll)

To do:

  • Add other breakpoints (FCR, FHR etc) and check if replacing an item with FCR or FHR for one with an item without (or an item with less FCR, FHR) will drop past a breakpoint.
  • Add handling of equippable quest items in D2Go
  • Add the +x in +x to skills. Currently it just adds a flat value if there is a relevant +x to skills. It should multiply the weighting by the +x. So if the weighting is 40, +3 to Blizzard should add 120 to the item score, it currently only adds 40 to the score.

CarlPoppa1 avatar Feb 25 '25 15:02 CarlPoppa1

@CarlPoppa1,

This definitely needs to be an option that can be enabled, not turned on at all times.

artosimonyan avatar Feb 26 '25 14:02 artosimonyan

@CarlPoppa1,

This definitely needs to be an option that can be enabled, not turned on at all times.

Definitely, I should have done that before raising the PR. Added here b428b0e7eea8450f2b7c803e62e188e183724fbd

CarlPoppa1 avatar Feb 28 '25 12:02 CarlPoppa1

@CarlPoppa1 Not a setting in the auto leveling script, but in the bot's settings. We can use the auto equip on newly leveled charms that just start to farm gear.

Add it as a main setting.

artosimonyan avatar Feb 28 '25 20:02 artosimonyan

@CarlPoppa1 Not a setting in the auto leveling script, but in the bot's settings. We can use the auto equip on newly leveled charms that just start to farm gear.

Add it as a main setting.

I'll need to do more work if that's how it's going to be implemented. Currently it won't work well for melee chars because it's forcing only a shield to be equipped in the right arm slot so barbs and assassins won't ever dual wield. I'll add it as a main setting once I've tested it on other supported classes apart from sorc

CarlPoppa1 avatar Mar 04 '25 16:03 CarlPoppa1

This is working pretty well so far, thanks for making it. The main issue I have is it switches weapons to far worse items. I've noticed a recurrance of weapons with single resists on them like +7 cold resist, +9 fire resist etc. So not sure if that's a coincidence or the route cause is related to the resists score. I'm running fire levling sorc and mostly have the leaf runeword equipped. So that's the other place the issue could be (without any proper code review). I haven't had the chance to test or add debug logs to check why it's happening sorry, but thought I'd comment in case you or others have this too.

Wamlad avatar Mar 09 '25 07:03 Wamlad

This is working pretty well so far, thanks for making it. The main issue I have is it switches weapons to far worse items. I've noticed a recurrance of weapons with single resists on them like +7 cold resist, +9 fire resist etc. So not sure if that's a coincidence or the route cause is related to the resists score. I'm running fire levling sorc and mostly have the leaf runeword equipped. So that's the other place the issue could be (without any proper code review). I haven't had the chance to test or add debug logs to check why it's happening sorry, but thought I'd comment in case you or others have this too.

Thanks. I've had to add handling for +x to Fire Skills to account for Leaf, Flickering Flame, Magefists etc.

I've also added support for other classes. I don't know how well the scoring will work for melee chars but I've added dual wield support for barbs and assassins, needs further testing though.

CarlPoppa1 avatar Mar 13 '25 14:03 CarlPoppa1

@CarlPoppa1 I am unsure what is happening, but instead of equipping items, it drops them on ground, no matter where they were located, stash or inventory. It then attempts to pick them back up over and over, then when it eventually does, it will sell them. It works great for equipping merc items though. I am not a coder, but have some general knowledge. Do you know what may be causing this?

Blacknight909 avatar Mar 13 '25 16:03 Blacknight909

@CarlPoppa1 I am unsure what is happening, but instead of equipping items, it drops them on ground, no matter where they were located, stash or inventory. It then attempts to pick them back up over and over, then when it eventually does, it will sell them. It works great for equipping merc items though. I am not a coder, but have some general knowledge. Do you know what may be causing this?

My bad, I thought I'd mention you need #684

CarlPoppa1 avatar Mar 13 '25 16:03 CarlPoppa1

@CarlPoppa1 I am unsure what is happening, but instead of equipping items, it drops them on ground, no matter where they were located, stash or inventory. It then attempts to pick them back up over and over, then when it eventually does, it will sell them. It works great for equipping merc items though. I am not a coder, but have some general knowledge. Do you know what may be causing this?

My bad, I thought I'd mention you need #684

Much appreciated, great work on this!

Blacknight909 avatar Mar 13 '25 16:03 Blacknight909

Issue 1:

Bot often gets stuck with item in hand LOG Entry: "Failed to equip % to % using hotkeys, trying cursor" then bot will have an Item on cursor and "move.go" or "Anti-idle triggered" is trying to move, that gets him stuck in a loop trying to move with item on cursor (cant use forcemove "E" with item on cursor)

It also looks that shift+leftclick is working properly, but bot is not recognizing it and shiftclicks the item back, then tries equipCursor and gets stuck

Edit:

It even says the current Location is "equipped" and still goes to the failsafe of using cursor to equip again.

time=06:12:45 level=ERROR msg="Failed to equip Club to equipped using hotkeys, trying cursor"

Edit2:

Will disable "equipCursor" for further testing

Issue 2:

Bot will sometimes decide to equip a Bow over an existing item and wont get arrwos for it, so it wont be able to do auto attacks until it luckily finds arrows while leveling

Timmynat0r avatar Mar 21 '25 05:03 Timmynat0r

Issue 1:

Bot often gets stuck with item in hand LOG Entry: "Failed to equip % to % using hotkeys, trying cursor" then bot will have an Item on cursor and "move.go" or "Anti-idle triggered" is trying to move, that gets him stuck in a loop trying to move with item on cursor (cant use forcemove "E" with item on cursor)

It also looks that shift+leftclick is working properly, but bot is not recognizing it and shiftclicks the item back, then tries equipCursor and gets stuck

Edit:

It even says the current Location is "equipped" and still goes to the failsafe of using cursor to equip again.

time=06:12:45 level=ERROR msg="Failed to equip Club to equipped using hotkeys, trying cursor"

Edit2:

Will disable "equipCursor" for further testing

Issue 2:

Bot will sometimes decide to equip a Bow over an existing item and wont get arrwos for it, so it wont be able to do auto attacks until it luckily finds arrows while leveling

Thanks again for testing. The most important issue (the cursor thing) should be fixed now. But please let me know if it happens again.

I've blacklisted bows and crossbows from being equipped until there's a proper way to implement them.

CarlPoppa1 avatar Mar 21 '25 16:03 CarlPoppa1