drupal-console icon indicating copy to clipboard operation
drupal-console copied to clipboard

[config:override] Changes values in active storage instead of "overriding" it

Open Aluquot opened this issue 6 years ago • 0 comments

Problem/Motivation

When using the config:override command I noticed that it actually writes the settings into the active storage. When reading the command name & description I actually expected to be "real overrides" as Drupal supports them. But those would be placed into the / a settings.*.php file. The benefit of real overrides is that their value are not exported when doing a config export.

As it stands the current functionalit is more like a config:set instead of an override.

How to reproduce

  1. Install Drupal with standard install profile.
  2. Export configuration to the sync folder
  3. Set a cofig override via config:override
  4. Go to the Configuration Sync page & see that the value is actually changed by the override because it differs from the exported one

Additional notes:

  • Drupal version: 8.4.0
  • Console versio: 1.0.0

Solution

  1. Rename to 'config:set' to make say what it does
  2. [optional] Implement 'config:override' in such a way that it actually is a Drupal-Override. The easiest might be to seperat 'overrides' into their own settings file that is setup to be includes by the settings.php.

Aluquot avatar Oct 12 '17 17:10 Aluquot