drupal-console-core icon indicating copy to clipboard operation
drupal-console-core copied to clipboard

Generator class don't uses GeneratorInterface

Open edysmp opened this issue 6 years ago • 1 comments

I see we have a GeneratorInterface but we don't use it, at least in Generator class.

I am creating a command which uses Generator feature, the generate:command by defualt set to use \Drupal\Console\Core\Generator\GeneratorInterface as paramater signature of my Command class. I get a TypeError like: MyGeneratorClass must implement interface GeneratorInterface.

edysmp avatar Jul 12 '19 23:07 edysmp

I fix this error whe i implements GeneratorInterface in my CustomGenerator. I see that generate:command generates this by default. But still should we implement this interface in the base Generator class instead?

edysmp avatar Jul 12 '19 23:07 edysmp